|
From: | Tom M. |
Subject: | Re: [fluid-dev] Current code overrides getopt.h declarations on Windows |
Date: | Sun, 22 Oct 2017 13:57:33 +0200 |
Hi,to me it looks like somebody read the getopt man page and took the synopsis as a usage example and not as a short description of the header file contents. I think the linesint getopt(int argc, char * const argv[], const char *optstring);extern char *optarg;extern int optind, opterr, optopt;can safely be removed.Cheers,Marcus2017-10-21 17:06 GMT+02:00 Tom M. <address@hidden>:clang-tidy also remarks that on Linux. Not sure why it has been done that way.Tom2017-10-21 17:01 GMT+02:00 Carlo Bramini <address@hidden>:Hello,
when compiling Fluidsynth on Windows, the compiler prints these messages into the console:
[ 97%] Building C object src/CMakeFiles/fluidsynth.dir/fluidsynth.c.o
/home/Carlo/fluidsynth/src/fluidsynth.c:67:14: warning: 'optarg' redeclared with out dllimport attribute: previous dllimport ignored [-Wattributes]
extern char *optarg;
^~~~~~
/home/Carlo/fluidsynth/src/fluidsynth.c:68:12: warning: 'optind' redeclared with out dllimport attribute: previous dllimport ignored [-Wattributes]
extern int optind, opterr, optopt;
^~~~~~
/home/Carlo/fluidsynth/src/fluidsynth.c:68:20: warning: 'opterr' redeclared with out dllimport attribute: previous dllimport ignored [-Wattributes]
extern int optind, opterr, optopt;
^~~~~~
/home/Carlo/fluidsynth/src/fluidsynth.c:68:28: warning: 'optopt' redeclared with out dllimport attribute: previous dllimport ignored [-Wattributes]
extern int optind, opterr, optopt;
^~~~~~
and actually it is right, because inside src/fluidsynth.c these variables are re-declarated and the dllimport attribute applied to them inside getopt.h is lost.
Is there a particular reason for doing this thing?
Sincerely,
Carlo Bramini.
_______________________________________________
fluid-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/fluid-dev
_______________________________________________
fluid-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/fluid-dev
_______________________________________________
fluid-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/fluid-dev
[Prev in Thread] | Current Thread | [Next in Thread] |