Re: [fluid-dev] [PATCH 0/4] OS/2 patches

[Tom M.]

I see, and because that __declspec() stuff is handled via the FLUIDSYNTH_API macro, I believe it's ok to just ignore fvisibility then.

Thanks!

Tom

2017-10-06 10:59 GMT+02:00 KO Myung-Hun <address@hidden>:

Hi/2.

fvisibility is ignored on Windows as well as OS/2. Instead, on those platforms, something such as__declspec(dllexport) and __declspec(dllimport) may be used.

I attach 4 patches.

KO Myung-Hun

--------------- Original message -------------

From : "Tom M."<address@hidden>
To : "FluidSynth mailing list"<address@hidden>
CC :
Date : Fri, 6 Oct 2017 16:19:28 +0900 (KST), Fri, 6 Oct 2017 09:19:04 +0200

Subject : Re: [fluid-dev] [PATCH 0/4] OS/2 patches

Oh, I was expecting to see the metadata in the text right before the patches, but as it seems they were embedded in the email itself. Anyway, yes please send them again as attached files.

If you're using 4.9 I dont quite understand why fvisibility is ignored. Is this a general OS/2 problem? Or just some temporary gcc problem (in which case I would feel uncomfortable applying PATCH 2/4)?

Tom

2017-10-06 4:14 GMT+02:00 Myung-Hun KO <address@hidden>:

Hi/2.

They are already ones got from git format-patch. And I sent them with
git send-email.

May be do you mean to attach the patch files to an e-mail not to send
them in each e-mail ?

I'm using GCC v4.9.2.

KO Myung-Hun

--------------- Original message -------------

From : "Tom M."<address@hidden>
To : "FluidSynth mailing list"<address@hidden>
CC :
Date : Thu, 5 Oct 2017 21:47:2 +0900 (KST), Thu, 5 Oct 2017 14:46:42 +0200
Subject : Re: [fluid-dev] [PATCH 0/4] OS/2 patches

Not familiar with OS/2, but the patches look fine to me. But could you
please use git format-patch instead? Just make your 4 commits and then
send the 4 .patch files you got via

git format-patch -4

BTW: What version of GCC are you using?

_______________________________________________
fluid-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/fluid-dev

_______________________________________________
fluid-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/fluid-dev