Re: [fluid-dev] Patch for channel_type, also XG drum-channel autoswitch

[Pedro Lopez-Cabanillas]

On Friday 04 February 2011, David Henningsson wrote:
> Hey jimmy,
> 
> Thanks for the research. I've committed the patch now (with some trivial 
> changes). Thanks for your contribution!

Agreed. Thanks!
 
> And to the rest of you - this bank select handling seems to be a never 
> ending debate, and it's not my area of expertise, so let me know if this 
> change screwed something up for you.

Looks OK, and also works fine in my tests with a few MIDI files created for XG 
synths that I've found in my HD.

You are perceiving that there is debate around this matter, when in fact the 
controversy comes from many years ago, when the MIDI manufacturers defined 
those different standards (GM, GS and XG) and people used the synths to  create 
MIDI files following each one. Now, to render those old MIDI files using 
FluidSynth we would like that FS  follow each one of the conventions as closely 
as possible. I've never been a XG user, so changeset #340 included several 
TODOs and FIXMEs that this patch has finally addressed. But there is still one 
(FIXME: pending implementation of SYSEX midi mode changes) that somebody has to 
work on, and there may be a few issues more than bank changes involved.

Regards,
Pedro