Re: map-y-or-n does not use minibuffer-prompt face

[Kim F. Storm]

"Lennart Borgman (gmail)" <address@hidden> writes:

> Kim F. Storm wrote:
>> "Lennart Borgman (gmail)" <address@hidden> writes:
>>
>>> Kim F. Storm wrote:
>>>> "Lennart Borgman (gmail)" <address@hidden> writes:
>>>>
>>>>> Kim F. Storm wrote:
>>>>>> "Lennart Borgman (gmail)" <address@hidden> writes:
>>>>>>
>>>>>>> Lennart Borgman (gmail) wrote:
>>>>>>>> The function `map-y-or-n-p' does not use minibuffer-prompt face.
>>>>>>> Here is a patch for this. I would be glad if someone installed
>>>>>>> it. As usual I do not want to touch for CVS at this time.
>>>>>> Thanks.
>>>>>>
>>>>>> I have installed a simpler change to fix this.
>>>>> Couild it be simpler? ;-)
>>>>>
>>>>> I am a bit curious but I can not find your change.
>>>> It's there :-)
>>>>
>>>> @@ -149,7 +149,8 @@
>>>>                 ;; Prompt in the echo area.
>>>>                 (let ((cursor-in-echo-area (not no-cursor-in-echo-area))
>>>>                       (message-log-max nil))
>>>> -                 (message "%s(y, n, !, ., q, %sor %s) "
>>>> +                 (message (apply 'propertize "%s(y, n, !, ., q, %sor %s) "
>>>> +                                 minibuffer-prompt-properties)
>>>>                            prompt user-keys
>>>>                            (key-description (vector help-char)))
>>>>                   (if minibuffer-auto-raise
>>>>
>>> Something like this in isearch.el then to be consistent:
>>>
>>>     (apply 'propertize (concat (upcase (substring m 0 1)) (substring m 1))
>>>             minibuffer-prompt-properties)))
>>>
>>>
>>> Can you install it?
>>
>> Why is it needed ?
>>
>> If I do C-s, the I-search prompt is in the correct face...
>
>
> That is because you have minibuffer-prompt in
> minibuffer-prompt-properties, but there could be some other face.

Well, I would consider that to be rather obscure.  

By definition, minibuffer-prompt is the face for minibuffer prompts,
and it should be safe to assume that, and not have to wade through
minibuffer-prompt-properties to see if the user has specified a
different face for the face property.

Placing some other face in minibuffer-prompt-properties
is against the intentions of that I think.

So IMO it is pretty obscure to allow the user to modify the
face property in the defcustom for minibuffer-prompt-properties.
If anything, it should be a boolean which says:

  [x] use minibuffer-prompt face

instead of allowing the user to change the face used.

-- 
Kim F. Storm <address@hidden> http://www.cua.dk