Re: custom-set-variables fails to set variable

[Bill Wohler]

Bill Wohler <address@hidden> writes:

> I've found a problem where my mh-letter-mode-hook (in MH-E) isn't
> getting called. It is listed properly in the custom-set-variables
> stanza, but when I start Emacs, load MH-E, and run customize-option on
> mh-letter-mode-hook, the hook is empty! When I enter the hook function,
> the hook works again.
>
> Is it because MH-E isn't loaded when custom-set-variables is run? Is it
> something MH-E is doing when it is loaded?
>
> I do not see this behavior under Emacs 21 so this is a regression.

It is not documented in NEWS, either.

> I intend to go through the rest of my customization variables to see if
> this a trend or an isolated problem. I'll follow up on this thread when
> I do.

Boy howdy! It is a trend. When I bring up a customization buffer for
each of my customization variables, some look good (are set correctly,
have a state of saved, and have documentation). However, the rest have
a value of "nil" or are just empty (mostly hooks), have a state of
"changed", and do not have documentation strings.

The ones that are OK are either in files that are in
preloaded-file-list or have ;;;###autoload cookies.

There are two solutions

1. Preserve the Emacs 21 semantics which had the effect of remembering
   customization settings in customize-set-variables so that when the
   modules were eventually loaded, the user's settings took
   precendence.

2. Add lots of lots of ;;;###autoload cookies to defcustoms
   everywhere. I am but one small user, but my list of broken
   customization variables is long (appended below).

I suspect that option #2 is the preferred approach as it has the
advantage of providing docstrings and customizationability to options
in unloaded packages.

It looks like the great majority of these are in the Gnus and MH-E
packages. If a Gnus person can handle the Gnus options, I can handle
the MH-E options, and Peter can handle the Debian options.

Richard, should someone take the responsibility of ensuring that all of
the defcustom options are autoloaded? Do *all* of the options need to
be autoloaded? Or just the "right ones" (whatever that is)?

----- List of broken options in ~wohler/.emacs.custom -----

    Man-notify-method
    c-backslash-column
    canlock-password
    cperl-font-lock
    cperl-indent-level
    cperl-lazy-help-time
    cperl-under-as-char
    cvs-confirm-removals
    debian-bug-always-CC-myself
    debian-bug-menu-action-default
    debian-bug-menu-preload-flag
    gnus-agent-expire-days
    gnus-asynchronous
    gnus-before-startup-hook
    gnus-default-article-saver
    gnus-directory
    gnus-group-line-format
    gnus-interactive-catchup
    gnus-interactive-exit
    gnus-large-newsgroup
    gnus-message-archive-group
    gnus-message-archive-method
    gnus-orphan-score
    gnus-read-active-file
    gnus-read-newsrc-file
    gnus-save-killed-list
    gnus-save-newsrc-file
    gnus-score-expiry-days
    gnus-secondary-select-methods
    gnus-summary-line-format
    gnus-summary-mode-hook
    gnus-thread-expunge-below
    gnus-thread-hide-subtree
    gnus-thread-sort-functions
    gnus-updated-mode-lines
    gnus-visible-headers
    gpg-passphrase-timeout
    ispell-program-name
    jde-db-source-directories
    jde-project-file-name
    jde-use-font-lock
    log-edit-hook
    lpr-page-header-program
    lpr-page-header-switches
    mail-source-delete-incoming
    mail-sources
    message-auto-save-directory
    message-directory
    message-mail-user-agent
    message-send-hook
    message-sent-hook
    message-user-organization
    mh-alias-insertion-location
    mh-auto-fields-list
    mh-before-quit-hook
    mh-before-send-letter-hook
    mh-compose-skipped-header-fields
    mh-compose-space-does-completion-flag
    mh-default-folder-must-exist-flag
    mh-default-folder-prefix
    mh-delete-yanked-msg-window-flag
    mh-display-buttons-for-alternatives-flag
    mh-do-not-confirm-flag
    mh-folder-mode-hook
    mh-identity-default
    mh-identity-list
    mh-inc-folder-hook
    mh-index-new-messages-folders
    mh-index-ticked-messages-folders
    mh-invisible-header-fields
    mh-invisible-header-fields-default
    mh-junk-background
    mh-junk-disposition
    mh-large-folder
    mh-letter-mode-hook
    mh-lpr-command-format
    mh-mime-save-parts-default-directory
    mh-quit-hook
    mh-recenter-summary-flag
    mh-recursive-folders-flag
    mh-reply-default-reply-to
    mh-show-mode-hook
    mh-show-threads-flag
    mh-show-use-goto-addr-flag
    mh-tool-bar-folder-buttons
    mh-yank-behavior
    mm-discouraged-alternatives
    mm-inline-large-images
    mm-inline-text-html-with-images
    mm-text-html-renderer
    nnmail-keep-last-article
    nnmail-prepare-incoming-hook
    pgg-encrypt-for-me
    pgg-query-keyserver
    smiley-data-directory
    speedbar-hide-button-brackets-flag
    speedbar-use-images
    w3m-content-type-alist
    w3m-key-binding
    w3m-use-favicon

-- 
Bill Wohler <address@hidden>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.