emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: w32-win.el's xw-defined-colors should not use `message'


From: Eli Zaretskii
Subject: Re: w32-win.el's xw-defined-colors should not use `message'
Date: Sat, 22 Jan 2005 10:24:59 +0200

> From: "Drew Adams" <address@hidden>
> Date: Fri, 21 Jan 2005 22:07:06 -0800
> 
> Function `xw-defined-colors' is defined in these places, independently:
> 
>  - w32-win.el
>  - mac-win.el
>  - x-win.el
> 
> In w32-win.el only, there is this inappropriate call to message:
> 
>  (message "Defining colors...")
> 
> The other versions of `xw-defined-colors' do not have a call to
> `message'. The function is not interactive, and there is no reason for
> the message.
> 
> This call to `message' should be removed.

I agree.  (It seems like it's a relic of some debugging session,
anyway.)

Jason?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]