[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: grep-tree bug
From: |
Jesper Harder |
Subject: |
Re: grep-tree bug |
Date: |
Sat, 22 May 2004 03:58:52 +0200 |
User-agent: |
Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) |
Richard Stallman <address@hidden> writes:
> But wouldn't it be friendlier if grep-tree could take care of this in
> some way?
>
> Yes, it should do something to make sure the name is a directory
> name, not a file name. It could perhaps call file-name-as-directory
> on the argument.
Yes, that seems to work. Do you want me to commit this change?
*** /home/harder/emacs/lisp/progmodes/grep.el.~1.12.~ Wed Apr 21 20:31:40 2004
--- /home/harder/emacs/lisp/progmodes/grep.el Sat May 22 03:57:11 2004
***************
*** 533,539 ****
(files
(read-string (concat "Search for \"" regexp "\" in files (default "
grep-tree-last-files "): ")))
(dir
! (read-directory-name "Base directory: " nil default-directory t)))
(list regexp files dir)))
(unless grep-tree-command
(grep-compute-defaults))
--- 533,540 ----
(files
(read-string (concat "Search for \"" regexp "\" in files (default "
grep-tree-last-files "): ")))
(dir
! (file-name-as-directory
! (read-directory-name "Base directory: " nil default-directory t))))
(list regexp files dir)))
(unless grep-tree-command
(grep-compute-defaults))
--
Jesper Harder <http://purl.org/harder/>