Re: help: adapting your library to new M-x compile

[Stefan Monnier]

>     - diff-mode.el:

>     A cleanup is included in my compile.el.  The question is why this
>     needs compilation-minor-mode at all, only to override its commands?

So that C-x ` can be used, but I think it's turned off now.

>     Even though the concepts don't quite fit, it might be interesting to
>     derive diff-mode from compilation-mode and let that do the parsing.

No, because it's not line-number based but text-content based: diff-mode
assumes that the file might have changed since the diff was generated and
only uses the line number as a hint.

>     - diff.el:

>     This little library messes around in internal variables extensively.  
> IMHO it should be merged into diff-mode, as it offers little extra.

> I would be glad if they were merged; it is ugly to have both.
> Would you like to do it?

I personally can't do it right now.  If we're willing to change the
behavior of M-x diff, (to match the one of diff-mode), then it's an
easy change.  Otherwise, it'll need improvements in diff-mode.


        Stefan