Re: Use of `gtk_window_set_icon_from_file' in src/xfns.c

[Lute Kamstra]

"Tim Van Holder" <address@hidden> writes:

>> As I understand things, there are three solutions:
>> 
>>    1. Revert the change.
>> 
>>    2. Let the configure script distinguish between 2.01 <= GTK < 2.2
>>       and GTK >= 2.2 and revert the change for the first case.
>> 
>>    3. Let the configure script require GTK >= 2.2 in order to compile
>>       Emacs with GTK.
>> 
>> The second option is probably best, but my knowledge of autoconf is
>> too limited to implement this.  Volunteers?
>
> I see option 3 has been applied, but the attached patchlet reverts it and
> implements option 2.  I've chosen an explicit version check in xfns.c;
> I suppose a configure-time check for either the gtk version or the
> specific function could work too.
> I guess it depends on whether the plan is to include more gtk 2.2+
> functionality or not - as it stands, this patch allows emacs to use GTK
> on not-so-cutting-edge Linux machines (e.g. RedHat pre-9.0).

I agree with Tim that this approach is better.  Maybe someone
knowledgeable on autoconf could apply a modified version of Tim's
patch?  That is, it seems to me that it is better to set HAVE_GTK_2_2
in configure.in and use that in src/xfns.c instead of the

(GTK_MAJOR_VERSION > 2 || (GTK_MAJOR_VERSION == 2 && GTK_MINOR_VERSION >= 2)) 

construct.

Lute.