Inf-loop in help-make-xrefs

[lawrence mitchell]

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

If a function is defined as below:

(defun test ()
  "This is a test function.

It uses the following keymap
\\{emacs-lisp-mode-map}."
  nil)

When doing (describe-function 'test), `help-make-xrefs' gets trapped
in an infloop when it gets to the end of the help buffer.  The
following patch fixed it for me.

----- begin -----
Index: help-mode.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/help-mode.el,v
retrieving revision 1.15
diff -u -r1.15 help-mode.el
--- help-mode.el        10 Feb 2003 21:52:30 -0000      1.15
+++ help-mode.el        19 Apr 2003 22:30:53 -0000
@@ -402,7 +402,8 @@
                                    (let ((sym (intern-soft (match-string 0))))
                                      (if (fboundp sym)
                                          (help-xref-button 0 'help-function 
sym))))
-                              (zerop (forward-line)))))))))
+                              (zerop (forward-line))
+                               (not (eobp)))))))))
           (set-syntax-table stab))
        ;; Delete extraneous newlines at the end of the docstring
        (goto-char (point-max))

-----  end  -----
In GNU Emacs 21.3.50.1 (i386-mingw-nt5.0.2195)
 of 2003-03-17 on YAM
configured using `configure --with-gcc (3.2)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: eng
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

-- 
lawrence mitchell <address@hidden>