>From f3dc39236e8f3940c58ab4e48f629360028131e1 Mon Sep 17 00:00:00 2001 From: Matt Lundin Date: Wed, 25 Jul 2018 07:48:10 -0500 Subject: [PATCH] Ensure that org-get-tags returns all local tags * lisp/org.el: (org-get-tags) Create a clearer separation between local and inherited tags in the function, so that org-remove-uninherited tags is only run on inherited tags. This is important to avoid destroying existing tags when adding new tags. * testing/lisp/test-org.el: (test-org/get-tags) Add regression test --- lisp/org.el | 15 ++++++++------- testing/lisp/test-org.el | 7 +++++++ 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 999575d05..94252489c 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -14722,14 +14722,15 @@ Inherited tags have the `inherited' text property." (org-with-point-at (or pos (point)) (unless (org-before-first-heading-p) (org-back-to-heading t) - (let ((tags (org--get-local-tags))) - (if (or local (not org-use-tag-inheritance)) tags + (let ((ltags (org--get-local-tags)) itags) + (if (or local (not org-use-tag-inheritance)) ltags + (setq itags org-file-tags) (while (org-up-heading-safe) - (setq tags (append (mapcar #'org-add-prop-inherited - (org--get-local-tags)) - tags))) - (org-remove-uninherited-tags - (delete-dups (append org-file-tags tags))))))))) + (setq itags (append (mapcar #'org-add-prop-inherited + (org--get-local-tags)) + itags))) + (delete-dups + (append (org-remove-uninherited-tags itags) ltags)))))))) (defun org-get-buffer-tags () "Get a table of all tags used in the buffer, for completion." diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el index a6b283163..20164beb5 100644 --- a/testing/lisp/test-org.el +++ b/testing/lisp/test-org.el @@ -6190,6 +6190,13 @@ Paragraph" (equal '("foo") (org-test-with-temp-text "* H1 :foo:\n* H2 :bar:" (org-get-tags 1)))) + ;; Make sure tags excluded from inheritance are returned if local + (should + (equal '("foo") + (org-test-with-temp-text "* Test :foo:" + (let ((org-use-tag-inheritance t) + (org-tags-exclude-from-inheritance '("foo"))) + (org-get-tags))))) ;; Pathological case: tagged headline with an empty body. (should (org-test-with-temp-text "* :tag:" (org-get-tags)))) -- 2.18.0