[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Reschedule "++" repeaters on same day if in future
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] Reschedule "++" repeaters on same day if in future |
Date: |
Thu, 30 Jun 2016 14:16:06 +0200 |
Hello,
Don March <address@hidden> writes:
> If you have a task with the following timestamp:
>
> SCHEDULED: <2016-06-19 Sun 21:00 ++1w>
>
> then marking it as DONE at [2016-06-27 at 07:00] should (debatably)
> result in
ISYM [2016-06-26 at 07:00].
> SCHEDULED: <2016-06-26 Sun 21:00 ++1w>
>
> but instead it becomes
>
> SCHEDULED: <2016-07-03 Sun 21:00 ++1w>
With the correction above, it makes sense, indeed.
> - (<= (time-to-days time)
> - (time-to-days (current-time))))
> + (or (time-less-p time (current-time))
> + (equal time (current-time))))
You should merge both `or'. Also, (equal time (current-time)) is always
nil since they don't have the same structure.
You could write instead
(while (or (= nshift 0)
(not (time-less-p (current-time) time)))
...)
It would be nice to add an explanation along with an example about that
in the manual, too. WDYT?
Thank you for your patch.
Regards,
--
Nicolas Goaziou