emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.


From: Dmitri Makarov
Subject: Re: [O] [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.
Date: Wed, 9 Sep 2015 17:59:47 +0200

This is refactored patch that uses org-mac-paste-applescript-links

Regards,

Dmitri


On Wed, Sep 9, 2015 at 4:11 PM, Alan Schmitt
<address@hidden> wrote:
> Hello,
>
> On 2015-09-09 12:42, Dmitri Makarov <address@hidden> writes:
>
>> This is my second attempt to submit a patch that enables grabbing
>> links from Adobe Acrobat Pro.
>
> I do not have Acrobat to test, but I have a small comment.
>
>> +(defun org-mac-acrobat-get-page ()
>> +  (interactive)
>> +  (message "Applescript: Getting Acrobat page link...")
>> +  (let* ((descriptor (as-get-acrobat-page-link))
>> +         (components (split-string descriptor "::"))
>> +         (path (car components))
>> +         (title (nth 1 components))
>> +         (page (nth 2 components))
>> +         (label (nth 3 components))
>> +         (link (concat "acrobat:" path "::" page))
>> +         (description (concat title ", p." label))
>> +         (org-link))
>> +    (when (not (string= link ""))
>> +      (setq org-link (org-make-link-string link description)))
>> +    (kill-new org-link)
>> +    org-link))
>
> Could you reuse `org-mac-paste-applescript-links' for this? For that,
> you need to add the "acrobat:" and the ", p." bits in the AppleScript
> (as is done for Skim).
>
> Best,
>
> Alan
>
> --
> OpenPGP Key ID : 040D0A3B4ED2E5C7
> Last week athmospheric CO₂ average (Updated September 6, 2015, Mauna Loa 
> Obs.):
> 377.86 ppm

Attachment: patch.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]