[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [RFC] [PATCH] ob-core.el: allow the auto-generation of output fi
|
From: |
Aaron Ecay |
|
Subject: |
Re: [O] [RFC] [PATCH] ob-core.el: allow the auto-generation of output file names for src blocks. |
|
Date: |
Thu, 15 May 2014 23:28:52 -0400 |
|
User-agent: |
Notmuch/0.17+160~g03680d1 (http://notmuchmail.org) Emacs/24.4.50.1 (x86_64-unknown-linux-gnu) |
Hi Achim,
2014ko maiatzak 14an, Achim Gratz-ek idatzi zuen:
> That breaks the tests for Octave and Maxima; since you're intentionally
> not keeping backwards compatibility here this should be fixed in the
> tests, I'd think.
Fixed. (It actually required changes to the code, not the tests, since
my commit made org-babel-graphical-output-file stricter).
>
> Also, I'd think you should be using "user-error" instead of error to
> generate the messages.
Good catch (especially since I recently pushed a patch changing some
errors to user-errors *blush*). Fixed.
Thanks,
--
Aaron Ecay