Re: [O] Highlighting bug with org-agenda-set-restriction-lock

[Carsten Dominik]

On 5 apr. 2013, at 16:12, Carsten Dominik <address@hidden> wrote:

> 
> On 5 apr. 2013, at 15:12, Bernt Hansen <address@hidden> wrote:
> 
>> Hi,
>> 
>> The highlighting has changed for this functionality.  I finally updated
>> to master (1200+ commits) yesterday and when I use C-c C-x < the entire
>> subtree is now highlighted in bright yellow on my Windows Emacs.
>> 
>> GNU Emacs 23.3.1 (i386-mingw-nt5.1.2600) of 2011-03-10 on 3249CTO
>> 
>> Org-mode version 7.9.2 (release_7.9.2-2030-g29a75d @
>> d:/bin/org-mode/lisp/)
>> 
>> This used to highlight only the first heading of the subtree.
>> Highlighting the entire subtree is _very_ distracting and makes working
>> in the org file on the narrowed subtree difficult (for me).
>> 
>> I can fix this by changing the face and completely removing the
>> highlight but I'd prefer the old functionality if that is possible.
> 
> This is causes by this commit:
> 
> commit aa0e0068de109eef2ac7897c4659d545b351de01
> Author: Bastien Guerry <address@hidden>
> Date:   Sat Feb 16 23:09:57 2013 +0100
> 
>    org-agenda.el (org-agenda-set-restriction-lock): Put the overlay until the 
> e
> 
>    * org-agenda.el (org-agenda-set-restriction-lock): Put the
>    overlay until the end of the subtree, not the end of the
>    headline.
> 
>    When the agenda restriction is on, user expect agenda views to check
>    every entry in the subtree.  If a user add an entry outside of the
>    overlay without noticing it, this entry will not be checked and the
>    user will wonder why.  Put the end of the overlay at the end of the
>    subtree so that the user always knows if the entries she is adding
>    are within the current restriction.
> 
>    We might need to find a less instrusive overlay color, though.
> 
> 
> So Bastien felt that the entire subtree should have an overlay, but
> maybe a softer color.  I would also prefer the highlight just to be
> on the headline as it used to be.
> 
> Bastien, how do you feel about reverting this change?  I see why
> you did it, but it is not so practical after all if you want to
> work in this mode for extended time.


I now also see that the patch did not achieve what the purpose of it was.  The 
problem is not the end of the overlay, but the position of the 
org-agenda-restriction-end marker.  Indeed, if you add tasks after this marker, 
they will not be included in the search.  There is not good work-around for 
this I can think of, so it is a problem we will have to live with.

- Carsten