[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [New Exporter] Parameterized wrapper elements
From: |
Jambunathan K |
Subject: |
Re: [O] [New Exporter] Parameterized wrapper elements |
Date: |
Sat, 09 Mar 2013 22:45:52 +0530 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Rick
I have my reservations in applying this patch - I am not concerned about
the patch, I have not looked at it.
Any improvements to existing backends should invariably answer the
question - "Can this change improve export tools or the parse tree
syntax."
If such a question is never asked and a answer sought, I would blame the
committer - whoever it be - in placing convenience and expediency above
the correct way to do things.
I have not looked at Rick's patch so my comment shouldn't be construed
as disapproval of the patch. I want the patch to improve exporter tools
and it has potential to improve the existing tools (maybe) in small ways
- an improvement is an improvement.
Jambunathan K.
Rick Frankel <address@hidden> writes:
> On Sat, Mar 09, 2013 at 10:32:11AM +0100, Bastien wrote:
>> Hi Rick,
>
>> One thing you may double-check in the meantime is: is it
>> compatible with the org-info.js utility? The default should
>> be "yes", even if users can replace "div" by something else
>> (e.g. for the needs of specific backends.)
>
> Yes. Checked the code and tested the script. It works on element ids
> and not element types, so changing the element type from `div' has no
> effect.
>
> The things that will break infojs are changing the following ids:
>
> - content
> - postamble
> - footnotes
> - table-of-contents
> - text-table-of-content
> - text-{slidenum}
>
> Note that the current implementation of `org-html-divs' will
> potentially break infojs as well.
>
> Attached is a revised patch with the fixes Nicolas found for the
> doc-string and the missing closing element.
>
> rick
>
--