Re: [O] [PATCH] narrowing in agenda file

[Litvinov Sergey]

Bernt Hansen <address@hidden> writes:
>   - org agenda clock reports are correct
>   - You don't have the LOGBOOK drawer aligned with tags when clocking in
>     from the agenda (this was with emacs -q (no org-indent-mode)
>   - Column view in the agenda shows correct clocking amounts for each
>     task
>   - Visiting a task with RET or SPC goes to the task when outside the
>     narrowed region
>   - Remote editing of a task outside the narrowed region changes the
>     target task and not something in your narrowed region instead

> I tried this patch today and clock reports in the agenda no longer
> display for me.  Could you take a look at it please?

Hi Bernt, 

thank you for the recommendations and for testing the patch. I am working
on ERT tests for the items you listed above. Also I found that
=org-agenda-add-note= does not work with narrowed agenda file.

Meanwhile I can share another patch to fix the problem with clock
reports (please see the second code block in
testing/examples/org-agenda-test.org )

>From 8824692191990c7ec4294b20c0c966bfc3e89de6 Mon Sep 17 00:00:00 2001
From: Litvinov Sergey <address@hidden>
Date: Wed, 1 Feb 2012 16:04:12 +0100
Subject: [PATCH 3/3] Fix clock reports in the agenda, add a test example for 
agenda

---
 lisp/org.el                          |    4 +++-
 testing/examples/org-agenda-test.org |   19 +++++++++++++++----
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 9e23c18..e1abbda 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -16498,6 +16498,8 @@ When a buffer is unmodified, it is just killed.  When 
modified, it is saved
        (inhibit-read-only t)
        (rea (concat ":" org-archive-tag ":"))
             bmp file re)
+    (save-excursion
+      (save-restriction
        (while (setq file (pop files))
          (catch 'nextfile
            (if (bufferp file)
@@ -16532,7 +16534,7 @@ When a buffer is unmodified, it is just killed.  When 
modified, it is saved
                  (while (re-search-forward re nil t)
                    (add-text-properties
                     (match-beginning 0) (org-end-of-subtree t) pc)))
-               (set-buffer-modified-p bmp)))))
+               (set-buffer-modified-p bmp)))))))
        (setq org-todo-keywords-for-agenda
              (org-uniquify org-todo-keywords-for-agenda))
        (setq org-todo-keyword-alist-for-agenda
diff --git a/testing/examples/org-agenda-test.org 
b/testing/examples/org-agenda-test.org
index ecd00e5..b16badb 100644
--- a/testing/examples/org-agenda-test.org
+++ b/testing/examples/org-agenda-test.org
@@ -1,10 +1,21 @@
 #+Title: a collection of examples for org-agenda tests
 * TODO should be visible
+  CLOCK: [2010-01-01 Fri 10:00]--[2010-01-01 Fri 10:05] =>  0:05
 ob-agenda-test.org buffer should be narrowed after execution of this block
 #+BEGIN_SRC elisp :results silent
-  (let ((org-agenda-files (list buffer-file-name)))
-    (narrow-to-region 1 (- (buffer-size) 23))
-    (org-agenda nil "t")
-    (org-agenda-redo))
+(let ((org-agenda-files (list buffer-file-name)))
+  (org-narrow-to-subtree)
+  (org-agenda nil "t")
+  (org-agenda-redo))
+#+END_SRC
+
+#+BEGIN_SRC elisp :results silent
+(let ((org-agenda-files (list buffer-file-name)))
+  (org-agenda nil "a")
+  (org-agenda-clockreport-mode 1)
+  (org-agenda-change-time-span 'year 2010)
+  (org-agenda-day-view 1)
+)
 #+END_SRC
 * TODO should be hidden
+  CLOCK: [2010-02-01 Mon 10:00]--[2010-02-01 Mon 10:05] =>  0:05
-- 
1.7.3.4