emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Fix regexps in org-clock.el


From: Carsten Dominik
Subject: Re: [O] [PATCH] Fix regexps in org-clock.el
Date: Sat, 31 Dec 2011 09:06:34 +0100

Applied, thanks.

But I have removed the regexp-quote again, because org-clock-string
is used in many more regexps, and a more complete patch would be
needed to make this change meaningful.

- Carsten

On 31.12.2011, at 08:34, Joe Vornehm Jr. wrote:

> I have been seeing persistent errors of "Cannot restart clock because task 
> does not contain unfinished clock" when auto-resuming a saved (persistent) 
> clock.  I believe I've tracked the error down to an extraneous space in a 
> regexp ("^[ \t]* " when it should be "^[ \t]*").
> 
> This patch fixes the issue for me (in `org-clock-in'), and it makes the same 
> change in `org-clock-find-position'.  I've tested this briefly and it works 
> for me; nothing about clocking-in behavior seems to break, and persistent 
> clocks work now.
> 
> I've also wrapped `regexp-quote' around instances where org-clock-string is 
> used to build a regexp, in case someone puts funny characters in their 
> org-clock-string.
> 
> Hopefully, the patch is attached correctly and Thunderbird didn't mangle it.
> 
> Cheers!
> Joe V.
> 
> 
> <0001-Fix-regexps-in-org-clock.el.patch>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]