emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH 1/5] Extend scope 'region to include body of last headlin


From: David Maus
Subject: Re: [O] [PATCH 1/5] Extend scope 'region to include body of last headline in active region
Date: Tue, 30 Aug 2011 06:33:09 +0200
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.2 (i486-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Hi Carsten,

At Thu, 25 Aug 2011 07:40:52 +0200,
Carsten Dominik wrote:
>
>
> On 25.8.2011, at 06:25, David Maus wrote:
>
> > * org.el (org-map-entries): Extend scope 'region to include entire
> > body of last headline in active region.
> > ---
> > lisp/org.el |    8 ++++++--
> > 1 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/lisp/org.el b/lisp/org.el
> > index de8c72b..b69b77c 100644
> > --- a/lisp/org.el
> > +++ b/lisp/org.el
> > @@ -13633,8 +13633,12 @@ a *different* entry, you cannot use these 
> > techniques."
> >            (org-narrow-to-subtree)
> >            (setq scope nil))
> >           ((and (eq scope 'region) (org-region-active-p))
> > -          (narrow-to-region (region-beginning) (region-end))
> > -          (setq scope nil)))
> > +          (let ((end (save-excursion
> > +                       (goto-char (region-end))
> > +                       (outline-next-heading)
> > +                       (point))))
> > +            (narrow-to-region (region-beginning) end)
> > +            (setq scope nil))))
>
>
> Hi David,
>
> I think the better algorithm here would be this:
> If region-end is at the beginning of a line and that line is a headline,
> use region-end as it is.  If not, jump to the next headline.

Thanks, yes. This makes sense. Attached patch supersedes the previous.

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... address@hidden
Email..... address@hidden

Attachment: 0001-Extend-scope-region-to-include-entire-body-of-last-h.patch
Description: Text document

Attachment: pgp5VwoseHoSM.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]