[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] org-bibtex.el --- convert between Org headings and bibte

From: Eric Schulte
Subject: Re: [O] [PATCH] org-bibtex.el --- convert between Org headings and bibtex entries
Date: Sat, 23 Apr 2011 08:07:06 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Matt Lundin <address@hidden> writes:

> Matt Lundin <address@hidden> writes:
>> "Eric Schulte" <address@hidden> writes:
>>> As one possible solution to this name conflict, I've folded my
>>> org-bibtex.el into the existing org-bibtex.el in the Org-mode core.  The
>>> attached patch performs this integration adding the functionality in my
>>> version of org-bibtex.el into the Org-mode core.
>>> Does this seem like an appropriate addition?
>> +1 (or maybe +.75 -- see below)
>> I think this could finally tempt me to move all my bibliographical data
>> into org-mode files. (I've been keeping all my data in a central bibtex
>> file and using reftex to generate links to citations.)
> I've been testing the patch and have a few comments. 
> 1. The prompt for the completing-read on line 440 is missing a space. It
>    shows "Type:" rather than "Type: ".

Fixed, Thanks

> 2. In addition, since the symbols in org-bibtex-types are keywords, the
>    completions are in the form ":article", ":book", etc. Might I ask why
>    everything is org-bibtex-type is a keyword? Could we use strings or
>    plain symbols instead? (Note: I haven't read the code carefully
>    enough to see if there is a reason.)

I tend to prefer keywords for items which are primarily used as keys
(e.g., for alist lookup w/assoc), I like that keywords are only interned
once and are clearly not variables or functions, however you're right
that it may add some extra complexity to this code.

I've changed the code which prompts for fields so that it now strips the
leading ":" from the keyword names, leading to nicer prompts.

> 3. The tooltip/help pop-up for org-bibtex-create takes up half a frame.

The pop-up buffer with field information should now only be as large as
required for the text (although if you have a vertically split frame the
buffer will not shrink).  It is using the same code used to minimize the
help buffer presented by `org-export'.

> Thanks,
> Matt

The updated version is contained in the attached patch.

Attachment: 0001-org-bibtex-translating-between-Org-mode-headings-and.patch
Description: Text Data

Thanks for your feedback.  I hope to hear from Carsten or Bastien (the
authors of the current org-bibtex) about whether this is the right place
for this functionality or if it should live somewhere else.

Best -- Eric

Eric Schulte

reply via email to

[Prev in Thread] Current Thread [Next in Thread]