emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: [Orgmode] [bug] org-link-escape and (wrong-type-argument


From: Carsten Dominik
Subject: Re: [PATCH] Re: [Orgmode] [bug] org-link-escape and (wrong-type-argument stringp nil)
Date: Wed, 29 Sep 2010 17:48:04 +0200

Hi David,

I have not have time to follow this in detail, but if you feel confident that this is doing the right thing, pleas go ahead and apply the necessary patches. I am an encoding moron, so I am easily convinced that you and Sebastian together cook up something useful. :-)

- Carsten

On Sep 27, 2010, at 7:36 AM, David Maus wrote:

Also I guess the decoding is secure.  Means we could change the
comment of this function:

(defun org-protocol-unhex-compound (hex)
 "Unhexify unicode hex-chars. E.g. `%C3%B6' is the German Umlaut `ö'.
Note: this function falls back on single byte decoding if a
character sequence is not valid utf-8.
See `org-protocol-unhex-single-byte-sequence'."


Should I send another patch against master?  (Too late here... for
me...)

Not necessary, following patch removed this sentence and added a
proper commit message (please see: Commit messages and ChangeLog
entries on http://orgmode.org/worg/org-contribute.php).

I took the new patch "under review" in patchtracker -- If someone else
wants to jump on it, just go ahead.

Best,
 -- David

Sebastian Rose (1):
 Decode single byte sequence if decoding unicode failed.

lisp/org-protocol.el |   26 +++++++++++++++++++++++---
1 files changed, 23 insertions(+), 3 deletions(-)


_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
address@hidden
http://lists.gnu.org/mailman/listinfo/emacs-orgmode




reply via email to

[Prev in Thread] Current Thread [Next in Thread]