emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] tag or property names with dashes


From: Carsten Dominik
Subject: Re: [Orgmode] tag or property names with dashes
Date: Mon, 30 Aug 2010 10:34:57 +0200

Hi Manish,

this looks pretty good.  I just went over the patch and
found something like 5 locations where you did not make
the change, and I fixed those.

Have you been testing your patch extensively?  Some testing
needs to be done before we can merge it.

- Carsten

On Aug 20, 2010, at 9:30 PM, Manish wrote:

On Sat, Aug 21, 2010 at 12:58 AM, Manish <address@hidden > wrote:
On Fri, Aug 20, 2010 at 11:02 PM, Manish wrote:
On Fri, Aug 20, 2010 at 7:15 PM, Carsten Dominik wrote:

On Aug 20, 2010, at 3:36 PM, Manish wrote:

[snip: accepting -'s in properties (17 lines)]

Are "#" and "%" are disallowed in the tags? Can they be made to work
please?

This is non-trivial and I shy away from the work for now. Make me a
patch and I will look at it.

Attempting something that /you/ call non-trivial is nigh impossible
for me. :(

But even if I were to dare.. any hints where I could start?


Attaching a naive first attempt. With this patch, I have tested special
behavior of ctrl-a/e respecting tags in org files, ascii and HTML
exports, agenda, and tag filtering. LaTeX export was not working so
could not test and do not have the setup for testing Docbook exports.
Please do take a look -- I do not understand the larger
repurcussions/side effects of the changes to all the regexes.

Thanks
-- Manish


This time _with_ patch.

-- Manish
<0001-Modified-regexes-to-accept-percent-and-hash-sign-as-.patch>

- Carsten






reply via email to

[Prev in Thread] Current Thread [Next in Thread]