Re: [Orgmode] [PATCH 5/5] clipboard handling in remember templats

[James TD Smith]

On 2008-04-09 17:32:22(+0200), Carsten Dominik wrote:
> Hi James,
> 
> I am going to accept this patch, but I do have a question about it:
> 
> On Mar 16, 2008, at 5:31 PM, James TD Smith wrote:
> 
> >From: James TD Smith <address@hidden>
> >
> >org.el |   56 +++++++++++++++++++++++++++++++++++++++++---------------
> >1 files changed, 41 insertions(+), 15 deletions(-)
> 
> [...]
> 
> >    (cond
> >     ((org-in-regexp org-bracket-link-regexp 1)
> >      ;; We do have a link at point, and we are going to edit it.
> >@@ -12579,7 +12583,7 @@ link description."
> >       (setq link  (org-make-link
> >                    "file:" (match-string 1 (expand-file-name file)))))
> >      (t (setq link (org-make-link "file:" file))))))
> >-     (t
> >+     ((not link)
> >      ;; Read link, with completion for stored links.
> 
> If you set it up like this, `link' will be overwritten be any link found at 
> point.
> Is you intention not to make the new argument link-location *overrule* 
> anything
> that might be at point?
No, it should override any links at point. 
> So maybe the first alternative in the cond should be just (link), to bypass 
> any parsing....
Yes.

James