[elpa] externals/relint cb1fdc5 06/44: Add caret pointing out the error in the quoted regexp

[Mattias Engdegård]

branch: externals/relint
commit cb1fdc5d10df9907df19afbe56e08165657684e9
Author: Mattias Engdegård <address@hidden>
Commit: Mattias Engdegård <address@hidden>

    Add caret pointing out the error in the quoted regexp
    
    This helps when regexp strings are long and contain many backslashes,
    which is frequently the case.
---
 trawl.el | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/trawl.el b/trawl.el
index 48ef364..0f97633 100644
--- a/trawl.el
+++ b/trawl.el
@@ -118,13 +118,21 @@
            str t t)
           "\""))
 
+(defun trawl--caret-string (string pos)
+  (let ((quoted-pos
+         (- (length (trawl--quote-string (substring string 0 pos)))
+            2)))                        ; Lop off quotes
+    (concat (make-string quoted-pos ?.) "^")))
+
 (defun trawl--check-re-string (re name file pos path)
   (let ((complaints
          (condition-case err
             (mapcar (lambda (warning)
-                       (format "In %s: %s (pos %d): %s"
-                               name (cdr warning) (car warning)
-                              (trawl--quote-string re)))
+                       (let ((pos (car warning)))
+                         (format "In %s: %s (pos %d)\n  %s\n   %s"
+                                 name (cdr warning) pos
+                                 (trawl--quote-string re)
+                                 (trawl--caret-string re pos))))
                     (xr-lint re))
           (error (list (format "In %s: Error: %s: %s"
                                name  (cadr err)
@@ -246,17 +254,6 @@
 
 (defun trawl--check-form-recursively (form file pos path)
   (pcase form
-;;;    (`(defun ,name ,_ . ,body)
-;;;     (let ((f body))
-;;;       (while (and f (consp (car f)) (eq (caar f) 'declare))
-;;;         (setq f (cdr f)))
-;;;       (when (and f (consp (car f)))
-;;;         (setq f (cdr f))
-;;;         (while (cdr f)
-;;;           (when (stringp (car f))
-;;;             (trawl--report file pos path
-;;;                        (format "defun %s: misplaced doc string" name)))
-;;;           (setq f (cdr f))))))
     (`(,(or `looking-at `re-search-forward `re-search-backward
             `string-match `string-match-p `looking-back `looking-at-p
             `replace-regexp-in-string `replace-regexp