[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/disk-usage f3895a3 27/48: Normalize some function names
From: |
Stefan Monnier |
Subject: |
[elpa] externals/disk-usage f3895a3 27/48: Normalize some function names |
Date: |
Tue, 19 Feb 2019 08:00:02 -0500 (EST) |
branch: externals/disk-usage
commit f3895a32ea49ca260008b489023fc3153f16feae
Author: Pierre Neidhardt <address@hidden>
Commit: Pierre Neidhardt <address@hidden>
Normalize some function names
---
disk-usage.el | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/disk-usage.el b/disk-usage.el
index 9856d5d..6fb7719 100644
--- a/disk-usage.el
+++ b/disk-usage.el
@@ -94,7 +94,6 @@
(defvar disk-usage--cache nil)
-
(cl-defstruct (disk-usage--file-info
(:constructor nil)
(:constructor disk-usage--file-info-make))
@@ -200,17 +199,17 @@ This is slow but does not require any external process."
(size-b (string-to-number (aref (cadr b) 0))))
(< size-a size-b)))
-(defvar disk-usage--format-size #'file-size-human-readable
+(defvar disk-usage--size-format-function #'file-size-human-readable
"How to print size.
Takes a number and returns a string.
`file-size-human-readable' and `number-to-string' are good candidates.")
(defvar disk-usage--sort #'disk-usage--sort-size-<)
-(defun disk-usage--set-format (&optional total-size)
+(defun disk-usage--set-tabulated-list-format (&optional total-size)
(setq tabulated-list-format
`[("Size"
- ,(if (eq disk-usage--format-size #'file-size-human-readable)
+ ,(if (eq disk-usage--size-format-function
#'file-size-human-readable)
8
12)
,disk-usage--sort . (:right-align t))
@@ -226,7 +225,7 @@ Takes a number and returns a string.
(defun disk-usage--refresh (&optional directory)
(setq directory (or directory default-directory))
(let ((listing (funcall disk-usage-list-function directory)))
- (disk-usage--set-format (disk-usage--total listing))
+ (disk-usage--set-tabulated-list-format (disk-usage--total listing))
(tabulated-list-init-header)
(setq tabulated-list-entries
(mapcar (lambda (file-info)
@@ -248,8 +247,8 @@ Takes a string and returns a string.
(defun disk-usage-toggle-human-readable ()
(interactive)
- (setq disk-usage--format-size
- (if (eq disk-usage--format-size #'file-size-human-readable)
+ (setq disk-usage--size-format-function
+ (if (eq disk-usage--size-format-function #'file-size-human-readable)
#'number-to-string
#'file-size-human-readable))
(tabulated-list-revert))
@@ -288,7 +287,7 @@ FILE-ENTRY may be a string or a button."
;; TODO: We could avoid defining our own `disk-usage--print-entry' by settings
;; `tabulated-list-entries' to a closure over the listing calling
-;; `disk-usage--format-size' to generate the columns.
+;; `disk-usage--size-format-function' to generate the columns.
(defun disk-usage--print-entry (id cols)
"Like `tabulated-list-print-entry' but formats size for human
beings."
@@ -303,7 +302,7 @@ beings."
(list (or (tabulated-list-get-entry (point-at-bol 0))
cols)
cols))))
- (setq x (tabulated-list-print-col 0 (funcall disk-usage--format-size
(string-to-number (aref cols 0))) x))
+ (setq x (tabulated-list-print-col 0 (funcall
disk-usage--size-format-function (string-to-number (aref cols 0))) x))
(setq x (tabulated-list-print-col 1 (disk-usage--print-file-col (aref
cols 1)) x))
(cl-loop for i from 2 below ncols
do (setq x (tabulated-list-print-col i (aref cols i) x))))
@@ -440,7 +439,7 @@ TYPE is the file extension (lower case)."
(< (disk-usage--type-average-size (car a))
(disk-usage--type-average-size (car b))))
-(defun disk-usage-by-types--set-format ()
+(defun disk-usage-by-types--set-tabulated-list-format ()
(setq tabulated-list-format
`[("Extension" 12 t)
("Count" 12 disk-usage--sort-by-count)
@@ -450,7 +449,7 @@ TYPE is the file extension (lower case)."
(defun disk-usage-by-types--refresh (&optional directory)
(setq directory (or directory default-directory))
(let ((listing (disk-usage-by-types--list directory)))
- (disk-usage-by-types--set-format)
+ (disk-usage-by-types--set-tabulated-list-format)
(tabulated-list-init-header)
(setq tabulated-list-entries
(cl-loop for e being the hash-values of listing
@@ -458,9 +457,9 @@ TYPE is the file extension (lower case)."
(vector
(disk-usage--type-info-extension e)
(number-to-string
(disk-usage--type-info-count e))
- (funcall disk-usage--format-size
+ (funcall disk-usage--size-format-function
(disk-usage--type-info-size e))
- (funcall disk-usage--format-size
+ (funcall disk-usage--size-format-function
(string-to-number
(format "%.2f"
(disk-usage--type-average-size e))))))))))
- [elpa] externals/disk-usage 3fb4803 07/48: Display total size, (continued)
- [elpa] externals/disk-usage 3fb4803 07/48: Display total size, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage b2497fd 19/48: Set buffer name in a defvar, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage ca3aa43 05/48: Display symlinks, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage f35eb8b 26/48: Refactor disk-usage-toggle-recursive, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage 9b55d63 09/48: Add disk-usage-toggle-full-path, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage f3bcae9 22/48: readme: Link to Guix, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage f330f01 31/48: Fix structure manipulation in disk-usage-by-types, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage 00aa40a 10/48: Bind "S-<return>" to disk-usage-find-file-at-point, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage 4fc5cb3 33/48: Refresh cache with prefix argument, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage 1949c82 37/48: Add disk-usage-by-types-here, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage f3895a3 27/48: Normalize some function names,
Stefan Monnier <=
- [elpa] externals/disk-usage 0d4ce4b 12/48: Bind "^" and "<backspace>" to disk-usage-up, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage aa3996e 24/48: Default to disk-usage--list, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage 90607dc 23/48: Use file-info structure instead of vectors, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage ed9dc23 11/48: Keep cursor on current entry when re-ordering buffer, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage dcfbd19 29/48: Rename sort functions, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage 0c135ed 21/48: Handle inaccessible directories, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage 19103ba 42/48: Add unmark-at-point, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage 3357ba9 32/48: Include screenshots, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage 2626642 15/48: Remove spurious "evil" keyword, Stefan Monnier, 2019/02/19
- [elpa] externals/disk-usage eefa57f 28/48: Turn disk-usage-size-format-function into a defcustom, Stefan Monnier, 2019/02/19