[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master 0af4163 1/8: Remove an old workaround from company-capf
From: |
Dmitry Gutov |
Subject: |
[elpa] master 0af4163 1/8: Remove an old workaround from company-capf |
Date: |
Sat, 8 Dec 2018 19:13:04 -0500 (EST) |
branch: master
commit 0af41635943deae8928f07888c84e6efd22d318a
Author: Dmitry Gutov <address@hidden>
Commit: Dmitry Gutov <address@hidden>
Remove an old workaround from company-capf
Seems to have been fixed in 4fa5a3753091b6911e27a8ff579a7861dc7ab9f9.
---
company-capf.el | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/company-capf.el b/company-capf.el
index 343edca..faac44c 100644
--- a/company-capf.el
+++ b/company-capf.el
@@ -147,20 +147,8 @@
(let ((f (plist-get (nthcdr 4 (company--capf-data)) :company-location)))
(when f (funcall f arg))))
(`annotation
- (save-excursion
- ;; FIXME: `company-begin' sets `company-point' after calling
- ;; `company--begin-new'. We shouldn't rely on `company-point' here,
- ;; better to cache the capf-data value instead. However: we can't just
- ;; save the last capf-data value in `prefix', because that command can
- ;; get called more often than `candidates', and at any point in the
- ;; buffer (https://github.com/company-mode/company-mode/issues/153).
- ;; We could try propertizing the returned prefix string, but it's not
- ;; passed to `annotation', and `company-prefix' is set only after
- ;; `company--strip-duplicates' is called.
- (when company-point
- (goto-char company-point))
- (let ((f (plist-get (nthcdr 4 (company--capf-data))
:annotation-function)))
- (when f (funcall f arg)))))
+ (let ((f (plist-get (nthcdr 4 (company--capf-data))
:annotation-function)))
+ (when f (funcall f arg))))
(`require-match
(plist-get (nthcdr 4 (company--capf-data)) :company-require-match))
(`init nil) ;Don't bother: plenty of other ways to initialize the
code.
- [elpa] master updated (652ba99 -> cd8bbda), Dmitry Gutov, 2018/12/08
- [elpa] master 373c078 2/8: company-capf: Use exit-function that came with the completion table in use, Dmitry Gutov, 2018/12/08
- [elpa] master b37cab3 6/8: company-completion-cancelled-hook: Don't remove-hook, Dmitry Gutov, 2018/12/08
- [elpa] master 23f930b 4/8: Make company-capf--current-completion-data buffer-local, Dmitry Gutov, 2018/12/08
- [elpa] master 5ed4918 3/8: Use company-capf--current-completion-data in more places, Dmitry Gutov, 2018/12/08
- [elpa] master 5adb0be 7/8: Release 0.9.8, Dmitry Gutov, 2018/12/08
- [elpa] master 0af4163 1/8: Remove an old workaround from company-capf,
Dmitry Gutov <=
- [elpa] master cd8bbda 8/8: Merge commit '5adb0be1dfa1c9767e888eee5892a10a1f81d582' from company, Dmitry Gutov, 2018/12/08
- [elpa] master 526aa5b 5/8: Discard company-capf--current-completion-data when we can, Dmitry Gutov, 2018/12/08