emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] master f3910a2 71/78: Add a comment justifying the duplication [c


From: Dmitry Gutov
Subject: [elpa] master f3910a2 71/78: Add a comment justifying the duplication [ci skip]
Date: Sun, 18 Feb 2018 07:40:28 -0500 (EST)

branch: master
commit f3910a2796f22ad57c51fad415c5acd804894de6
Author: Dmitry Gutov <address@hidden>
Commit: Dmitry Gutov <address@hidden>

    Add a comment justifying the duplication [ci skip]
---
 company.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/company.el b/company.el
index b057e01..a1fe54d 100644
--- a/company.el
+++ b/company.el
@@ -926,6 +926,12 @@ matches IDLE-BEGIN-AFTER-RE, return it wrapped in a cons."
           (if (> (- (time-to-seconds) start) company-async-timeout)
               (error "Company: backend %s async timeout with args %s"
                      backend args)
+            ;; XXX: Reusing the trick from company--fetch-candidates here
+            ;; doesn't work well: sit-for isn't a good fit when we want to
+            ;; ignore pending input (results in too many calls).
+            ;; FIXME: We should deal with this by standardizing on a kind of
+            ;; Future object that knows how to sync itself. In most cases (but
+            ;; not all), by calling accept-process-output, probably.
             (sleep-for company-async-wait)))
         res))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]