emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/exwm 46e1d7a 1/4: Use let instead of setq when setting


From: Chris Feng
Subject: [elpa] externals/exwm 46e1d7a 1/4: Use let instead of setq when setting exwm-input--line-mode-passthrough
Date: Fri, 24 Feb 2017 10:31:54 -0500 (EST)

branch: externals/exwm
commit 46e1d7a754bdf66cf89e6d3fad3d1c4bf003db3a
Author: Steven Allen <address@hidden>
Commit: Steven Allen <address@hidden>

    Use let instead of setq when setting exwm-input--line-mode-passthrough
    
    That way, exwm won't clobber user modifications to this variable.
---
 exwm-input.el | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/exwm-input.el b/exwm-input.el
index d410bec..22e21d6 100644
--- a/exwm-input.el
+++ b/exwm-input.el
@@ -629,16 +629,15 @@ This value should always be overwritten.")
   (let (key keys)
     (dotimes (i times)
       ;; Skip events not from keyboard
-      (setq exwm-input--line-mode-passthrough t)
-      (catch 'break
-        (while t
-          (setq key (read-key (format "Send key: %s (%d/%d)"
-                                      (key-description keys)
-                                      (1+ i) times)))
-          (when (and (listp key) (eq (car key) t))
-            (setq key (cdr key)))
-          (unless (listp key) (throw 'break nil))))
-      (setq exwm-input--line-mode-passthrough nil)
+      (let ((exwm-input--line-mode-passthrough t))
+        (catch 'break
+          (while t
+            (setq key (read-key (format "Send key: %s (%d/%d)"
+                                        (key-description keys)
+                                        (1+ i) times)))
+            (when (and (listp key) (eq (car key) t))
+              (setq key (cdr key)))
+            (unless (listp key) (throw 'break nil)))))
       (setq keys (vconcat keys (vector key)))
       (exwm-input--fake-key key))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]