[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master bea6942 13/49: Unbind js2-mode-show-node
From: |
Dmitry Gutov |
Subject: |
[elpa] master bea6942 13/49: Unbind js2-mode-show-node |
Date: |
Mon, 16 Jan 2017 15:35:47 +0000 (UTC) |
branch: master
commit bea6942f87c972a70a8b34424436db8b1f917693
Author: Dmitry Gutov <address@hidden>
Commit: Dmitry Gutov <address@hidden>
Unbind js2-mode-show-node
Fixes #356.
---
js2-mode.el | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/js2-mode.el b/js2-mode.el
index 5f0f3c1..1e7f61b 100644
--- a/js2-mode.el
+++ b/js2-mode.el
@@ -1130,7 +1130,6 @@ information."
(defvar js2-mode-map
(let ((map (make-sparse-keymap)))
- (define-key map [mouse-1] #'js2-mode-show-node)
(define-key map (kbd "M-j") #'js2-line-break)
(define-key map (kbd "C-c C-e") #'js2-mode-hide-element)
(define-key map (kbd "C-c C-s") #'js2-mode-show-element)
@@ -11400,7 +11399,6 @@ If so, we don't ever want to use bounce-indent."
(defvar js2-minor-mode-map
(let ((map (make-sparse-keymap)))
(define-key map (kbd "C-c C-`") #'js2-next-error)
- (define-key map [mouse-1] #'js2-mode-show-node)
map)
"Keymap used when `js2-minor-mode' is active.")
@@ -11732,11 +11730,15 @@ buffer will only rebuild its `js2-mode-ast' if the
buffer is dirty."
(unless interrupted-p
(setq js2-mode-parse-timer nil))))))
-(defun js2-mode-show-node (event)
+;; We bound it to [mouse-1] previously. But the signature of
+;; mouse-set-point changed around 24.4, so it's kind of hard to keep
+;; it working in 24.1-24.3. Since the command is not hugely
+;; important, we removed the binding (#356). Maybe we'll bring it
+;; back when supporting <24.4 is not a goal anymore.
+(defun js2-mode-show-node (event &optional promote-to-region)
"Debugging aid: highlight selected AST node on mouse click."
- (interactive "e")
- (mouse-set-point event)
- (setq deactivate-mark t)
+ (interactive "e\np")
+ (mouse-set-point event promote-to-region)
(when js2-mode-show-overlay
(let ((node (js2-node-at-point))
beg end)
- [elpa] master b23d9e4 01/49: Fix Highlighting function name of form {"quoted name" () {...}}, (continued)
- [elpa] master b23d9e4 01/49: Fix Highlighting function name of form {"quoted name" () {...}}, Dmitry Gutov, 2017/01/16
- [elpa] master abe8d0c 02/49: Fix comment alignment, Dmitry Gutov, 2017/01/16
- [elpa] master 8e7ed39 06/49: Merge pull request #348 from dunn/makequiet, Dmitry Gutov, 2017/01/16
- [elpa] master 357547c 09/49: js2-jsx-mode docstring fix, Dmitry Gutov, 2017/01/16
- [elpa] master 2b32301 15/49: Propertize regexp starting with /= correctly, Dmitry Gutov, 2017/01/16
- [elpa] master 68db1f5 05/49: Makefile: use -Q to avoid site-lisp loading, Dmitry Gutov, 2017/01/16
- [elpa] master 4e5babf 03/49: Merge pull request #345 from jacott/master, Dmitry Gutov, 2017/01/16
- [elpa] master 980eb3d 04/49: Support ES7 exponentiation, Dmitry Gutov, 2017/01/16
- [elpa] master 49f9761 08/49: js2-jsdoc-arg-tag-regexp: Recognize @module, Dmitry Gutov, 2017/01/16
- [elpa] master e45206b 11/49: js2-parse-class: Convert positions to relative for NAME and EXTENDS, too, Dmitry Gutov, 2017/01/16
- [elpa] master bea6942 13/49: Unbind js2-mode-show-node,
Dmitry Gutov <=
- [elpa] master c0801b2 12/49: Propertize regexp literals like js-mode does, Dmitry Gutov, 2017/01/16
- [elpa] master 9a8aaa9 28/49: Fix length of name in namespace-import nodes, Dmitry Gutov, 2017/01/16
- [elpa] master 44c289f 24/49: Copy edits, Dmitry Gutov, 2017/01/16
- [elpa] master b6d9301 17/49: Merge pull request #377 from XeCycle/memfn-delete, Dmitry Gutov, 2017/01/16
- [elpa] master 64ec0a2 14/49: Allow newline in globals declaration, Dmitry Gutov, 2017/01/16
- [elpa] master 2801681 26/49: Fix "pos" argument in template node constructors, Dmitry Gutov, 2017/01/16
- [elpa] master 712dfb0 29/49: Merge pull request #384 from mishoo/master, Dmitry Gutov, 2017/01/16
- [elpa] master df06798 23/49: Merge pull request #378 from JulianKniephoff/include-externs-locally, Dmitry Gutov, 2017/01/16
- [elpa] master 2a79649 33/49: Fix indentation after regexp in js2-old-indent.el, Dmitry Gutov, 2017/01/16
- [elpa] master f450de0 34/49: Handle destructuring assignments when classifying variables, Dmitry Gutov, 2017/01/16