[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/eglot2emacs 9adb310e08 021/120: Don't error out on unsupported d
From: |
João Távora |
Subject: |
feature/eglot2emacs 9adb310e08 021/120: Don't error out on unsupported diagnostic.codedescription |
Date: |
Thu, 20 Oct 2022 07:16:46 -0400 (EDT) |
branch: feature/eglot2emacs
commit 9adb310e08410b555651d7b819671842bd99f2c1
Author: Brian Leung <bkleung89@gmail.com>
Commit: Stefan Kangas <stefankangas@gmail.com>
Don't error out on unsupported diagnostic.codedescription
A codeDescription property is, at the time of writing, an object with
an href property (of type URI, or a string), denoting a "URI to open
with more information about the diagnostic error".
It's not obvious how best to put this into a Flymake diagostic
aside from simply appending it to the diagnostic message, so we'll
worry about it some other time.
* eglot.el (eglot--lsp-interface-alist)
(eglot-client-capabilities): Don't error out on unsupported
Diagnostic.codeDescription.
GitHub-reference: fix https://github.com/joaotavora/eglot/issues/768
---
lisp/progmodes/eglot.el | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 80eb58f579..bdd0dcccc5 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -351,7 +351,7 @@ This can be useful when using docker to run a language
server.")
:sortText :filterText :insertText
:insertTextFormat
:textEdit :additionalTextEdits :commitCharacters
:command :data))
- (Diagnostic (:range :message) (:severity :code :source
:relatedInformation))
+ (Diagnostic (:range :message) (:severity :code :source
:relatedInformation :codeDescription))
(DocumentHighlight (:range) (:kind))
(FileSystemWatcher (:globPattern) (:kind))
(Hover (:contents) (:range))
@@ -689,7 +689,11 @@ treated as in `eglot-dbind'."
:formatting `(:dynamicRegistration :json-false)
:rangeFormatting `(:dynamicRegistration :json-false)
:rename `(:dynamicRegistration :json-false)
- :publishDiagnostics `(:relatedInformation :json-false))
+ :publishDiagnostics (list :relatedInformation :json-false
+ ;; TODO: We can support
:codeDescription after
+ ;; adding an appropriate UI to
+ ;; Flymake.
+ :codeDescriptionSupport :json-false))
:experimental eglot--{})))
(defclass eglot-lsp-server (jsonrpc-process-connection)
- feature/eglot2emacs 426d97f172 001/120: ; prefer https to http addresses, (continued)
- feature/eglot2emacs 426d97f172 001/120: ; prefer https to http addresses, João Távora, 2022/10/20
- feature/eglot2emacs fb8706165c 004/120: Use fortls also for fortran-mode, João Távora, 2022/10/20
- feature/eglot2emacs a218f52ec9 012/120: Un-reverse references in xref buffer, João Távora, 2022/10/20
- feature/eglot2emacs be1e214fb2 013/120: Add cmake-language-server for cmake-mode, João Távora, 2022/10/20
- feature/eglot2emacs 512d8b9f59 011/120: Add variable to withhold the init req process id, João Távora, 2022/10/20
- feature/eglot2emacs 09c071d3d1 019/120: Add tooltip describing pending requests, João Távora, 2022/10/20
- feature/eglot2emacs f0b9018f52 018/120: Properly print error message of eglot-alternatives, João Távora, 2022/10/20
- feature/eglot2emacs ae7315b5f1 016/120: ; fix license statement, João Távora, 2022/10/20
- feature/eglot2emacs 49e46c3d53 017/120: Add up-to-date server executables for html/css/json, João Távora, 2022/10/20
- feature/eglot2emacs 34c7da506d 020/120: Support autoimporttext from pyright language server, João Távora, 2022/10/20
- feature/eglot2emacs 9adb310e08 021/120: Don't error out on unsupported diagnostic.codedescription,
João Távora <=
- feature/eglot2emacs 0f44d338f1 025/120: Support optional diagnostic.tags, João Távora, 2022/10/20
- feature/eglot2emacs 0739cdcf20 031/120: Improve backwards-compatibility of eglot-mode-map, João Távora, 2022/10/20
- feature/eglot2emacs 9710754080 042/120: Add support for optional completionitem.tags, João Távora, 2022/10/20
- feature/eglot2emacs c2d97d22aa 056/120: Implement on-type-formatting support, João Távora, 2022/10/20
- feature/eglot2emacs 1d9542cbe8 059/120: Protect against empty firsttriggercharacter strings, João Távora, 2022/10/20
- feature/eglot2emacs a63916f928 062/120: Tweak eglot mode-line menus, João Távora, 2022/10/20
- feature/eglot2emacs 4beab004d9 070/120: Ensure exit-function of eglot-c-at-point runs on exact match, João Távora, 2022/10/20
- feature/eglot2emacs 29f2ec2471 071/120: Consider diagnostic.code when generating flymake diagnostics, João Távora, 2022/10/20
- feature/eglot2emacs cc5d1a5a72 091/120: Always default eglot-strict-mode to nil, João Távora, 2022/10/20
- feature/eglot2emacs e74e199912 093/120: Add out-of-box support for perl lsp server, João Távora, 2022/10/20