Re: [Emacs-diffs] master updated (05b7953 -> b2b1ccb)

[Paul Eggert]

On 5/20/19 11:47 AM, Alex Gramiak wrote:
> Hmm, this is weird: the warnings seem to be legitimate
> (get_per_char_metric can return NULL)

No, the warnings are not legitimate. Those calls to get_per_char_metric 
occur only when get_char_glyph_code succeeds, and when that happens 
get_per_char_metric cannot fail.

I wouldn't worry about bogus warnings issued by older instances of GCC, 
or issued by GCC with non-default build options. There are too many such 
warnings, and we'd waste time (and clutter up the code, perhaps 
incorrectly) pacifying them. Just worry about the latest GCC with 
default build options.