[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] harfbuzz 1a80b5d 2/2: Clarify one FIXME a bit
From: |
Khaled Hosny |
Subject: |
[Emacs-diffs] harfbuzz 1a80b5d 2/2: Clarify one FIXME a bit |
Date: |
Sun, 23 Dec 2018 21:01:37 -0500 (EST) |
branch: harfbuzz
commit 1a80b5d9b8cfa0e523b596db5d1e7e6074dbee46
Author: Khaled Hosny <address@hidden>
Commit: Khaled Hosny <address@hidden>
Clarify one FIXME a bit
---
src/ftfont.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/ftfont.c b/src/ftfont.c
index bc37a6a..74d72f9 100644
--- a/src/ftfont.c
+++ b/src/ftfont.c
@@ -2850,8 +2850,8 @@ ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face
ft_face, hb_font_t *hb_font,
return Qnil;
glyph_len = hb_buffer_get_length (hb_buffer);
- /* FIXME: number of output glyphs can legitimately be larger than number of
- * output characters, what to do in this case? */
+ /* FIXME: can't we just grew the lgstring in this case? Givving up is an
+ * overly heavy handed solution. */
if (glyph_len > LGSTRING_GLYPH_LEN (lgstring))
return Qnil;