[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 9a8bbb9: ; Fix previous commit

From: Mark Oteiza
Subject: [Emacs-diffs] master 9a8bbb9: ; Fix previous commit
Date: Wed, 13 Sep 2017 10:21:55 -0400 (EDT)

branch: master
commit 9a8bbb9d5d3a55d4a31658e188f305669bd26e79
Author: Mark Oteiza <address@hidden>
Commit: Mark Oteiza <address@hidden>

    ; Fix previous commit
    Removing extraneous code, thanks to Michael Heerdegen.
    * lisp/emacs-lisp/subr-x.el (internal--listify): Remove latter
    condition which always evaluates to t.
    (internal--build-binding-value-form): Remove dead code.
 lisp/emacs-lisp/subr-x.el | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lisp/emacs-lisp/subr-x.el b/lisp/emacs-lisp/subr-x.el
index 3ea0106..ba0ab6c 100644
--- a/lisp/emacs-lisp/subr-x.el
+++ b/lisp/emacs-lisp/subr-x.el
@@ -87,9 +87,7 @@ threading."
 If ELT is of the form ((EXPR)), listify (EXPR) with a dummy symbol."
    ((symbolp elt) (list elt elt))
-   ((and (null (cdr elt))
-         (let ((form (car elt)))
-           (or (listp form) (atom form))))
+   ((null (cdr elt))
     (list (make-symbol "s") (car elt)))
    (t elt)))
@@ -104,9 +102,7 @@ If ELT is of the form ((EXPR)), listify (EXPR) with a dummy 
 (defsubst internal--build-binding-value-form (binding prev-var)
   "Build the conditional value form for BINDING using PREV-VAR."
   (let ((var (car binding)))
-    (if (and (null (cdr binding)) (atom (car binding)) (not (symbolp (car 
-        `(,var (and ,prev-var ,var))
-      `(,var (and ,prev-var ,(cadr binding))))))
+    `(,var (and ,prev-var ,(cadr binding)))))
 (defun internal--build-binding (binding prev-var)
   "Check and build a single BINDING with PREV-VAR."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]