[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 19584f1 1/2: Remove unsafe enriched mode translatio

From: Paul Eggert
Subject: [Emacs-diffs] master 19584f1 1/2: Remove unsafe enriched mode translations
Date: Sat, 9 Sep 2017 18:30:12 -0400 (EDT)

branch: master
commit 19584f13b1e2e4a778602a8302619ef5c675e68b
Author: Lars Ingebrigtsen <address@hidden>
Commit: Paul Eggert <address@hidden>

    Remove unsafe enriched mode translations
    * lisp/gnus/mm-view.el (mm-inline-text):
    Do not worry about enriched or richtext type.
    * lisp/textmodes/enriched.el (enriched-translations):
    Remove translations for FUNCTION, display (Bug#28350).
    (enriched-handle-display-prop, enriched-decode-display-prop): Remove.
 lisp/gnus/mm-view.el       |  4 ----
 lisp/textmodes/enriched.el | 32 --------------------------------
 2 files changed, 36 deletions(-)

diff --git a/lisp/gnus/mm-view.el b/lisp/gnus/mm-view.el
index 9ff581d..3698f4d 100644
--- a/lisp/gnus/mm-view.el
+++ b/lisp/gnus/mm-view.el
@@ -362,10 +362,6 @@
        (goto-char (point-max))))
       (narrow-to-region b (point))
-      (when (member type '("enriched" "richtext"))
-        (set-text-properties (point-min) (point-max) nil)
-       (ignore-errors
-         (enriched-decode (point-min) (point-max))))
        `(lambda ()
diff --git a/lisp/textmodes/enriched.el b/lisp/textmodes/enriched.el
index 7ace2a5..eba7c4d 100644
--- a/lisp/textmodes/enriched.el
+++ b/lisp/textmodes/enriched.el
@@ -117,12 +117,7 @@ expression, which is evaluated to get the string to 
                   (full        "flushboth")
                   (center      "center"))
     (PARAMETER     (t           "param")) ; Argument of preceding annotation
-    ;; The following are not part of the standard:
-    (FUNCTION      (enriched-decode-foreground "x-color")
-                  (enriched-decode-background "x-bg-color")
-                  (enriched-decode-display-prop "x-display"))
     (read-only     (t           "x-read-only"))
-    (display      (nil         enriched-handle-display-prop))
     (unknown       (nil         format-annotate-value))
 ;   (font-size     (2           "bigger")       ; unimplemented
 ;                 (-2          "smaller"))
@@ -477,32 +472,5 @@ Return value is \(begin end name positive-p), or nil if 
none was found."
     (message "Warning: no color specified for <x-bg-color>")
-;;; Handling the `display' property.
-(defun enriched-handle-display-prop (old new)
-  "Return a list of annotations for a change in the `display' property.
-OLD is the old value of the property, NEW is the new value.  Value
-is a list `(CLOSE OPEN)', where CLOSE is a list of annotations to
-close and OPEN a list of annotations to open.  Each of these lists
-has the form `(ANNOTATION PARAM ...)'."
-  (let ((annotation "x-display")
-       (param (prin1-to-string (or old new))))
-    (if (null old)
-        (cons nil (list (list annotation param)))
-      (cons (list (list annotation param)) nil))))
-(defun enriched-decode-display-prop (start end &optional param)
-  "Decode a `display' property for text between START and END.
-PARAM is a `<param>' found for the property.
-Value is a list `(START END SYMBOL VALUE)' with START and END denoting
-the range of text to assign text property SYMBOL with value VALUE."
-  (let ((prop (when (stringp param)
-               (condition-case ()
-                   (car (read-from-string param))
-                 (error nil)))))
-    (unless prop
-      (message "Warning: invalid <x-display> parameter %s" param))
-    (list start end 'display prop)))
 ;;; enriched.el ends here

reply via email to

[Prev in Thread] Current Thread [Next in Thread]