emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 6eaadcc: Treat incomplete integer literals as error


From: Philipp Stephani
Subject: [Emacs-diffs] master 6eaadcc: Treat incomplete integer literals as errors
Date: Fri, 23 Dec 2016 12:21:51 +0000 (UTC)

branch: master
commit 6eaadcc7c821b7a8c75ce6d1d56cd7f50898f809
Author: Philipp Stephani <address@hidden>
Commit: Philipp Stephani <address@hidden>

    Treat incomplete integer literals as errors
    
    See Bug#25120.
    
    * src/lread.c (read_integer): Treat incomplete integer literals as errors.
    * test/src/lread-tests.el (lread-empty-int-literal): New unit test for
    incomplete integer literals.
---
 src/lread.c             |    2 +-
 test/src/lread-tests.el |    8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/lread.c b/src/lread.c
index fdbf032..35348f1 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -2536,7 +2536,7 @@ read_integer (Lisp_Object readcharfun, EMACS_INT radix)
       *p = '\0';
     }
 
-  if (! valid)
+  if (valid != 1)
     {
       sprintf (buf, "integer, radix %"pI"d", radix);
       invalid_syntax (buf);
diff --git a/test/src/lread-tests.el b/test/src/lread-tests.el
index 1a82d13..609f82e 100644
--- a/test/src/lread-tests.el
+++ b/test/src/lread-tests.el
@@ -104,4 +104,12 @@
 (ert-deftest lread-string-char-name ()
   (should (equal (read "\"a\\N{SYLOTI NAGRI  LETTER DHO}b\"") "a\uA817b")))
 
+(ert-deftest lread-empty-int-literal ()
+  "Check that Bug#25120 is fixed."
+  (should-error (read "#b") :type 'invalid-read-syntax)
+  (should-error (read "#o") :type 'invalid-read-syntax)
+  (should-error (read "#x") :type 'invalid-read-syntax)
+  (should-error (read "#24r") :type 'invalid-read-syntax)
+  (should-error (read "#") :type 'invalid-read-syntax))
+
 ;;; lread-tests.el ends here



reply via email to

[Prev in Thread] Current Thread [Next in Thread]