emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] trunk r116969: Remove deprecated optional argument of make


From: Eli Zaretskii
Subject: [Emacs-diffs] trunk r116969: Remove deprecated optional argument of make-face.
Date: Sat, 12 Apr 2014 14:26:38 +0000
User-agent: Bazaar (2.6b2)

------------------------------------------------------------
revno: 116969
revision-id: address@hidden
parent: address@hidden
author: Matthias Dahl <address@hidden>
committer: Eli Zaretskii <address@hidden>
branch nick: trunk
timestamp: Sat 2014-04-12 17:25:53 +0300
message:
  Remove deprecated optional argument of make-face.
  
   lisp/faces.el (make-face): Remove deprecated optional argument. The
   conditional application of X resources is handled directly by
   make-face-x-resource-internal since Emacs 24.4.
   (make-empty-face): Don't pass optional argument to make-face.
modified:
  lisp/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-1432
  lisp/faces.el                  faces.el-20091113204419-o5vbwnq5f7feedwu-562
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2014-04-11 06:51:49 +0000
+++ b/lisp/ChangeLog    2014-04-12 14:25:53 +0000
@@ -1,3 +1,10 @@
+2014-04-12  Matthias Dahl  <address@hidden>
+
+       * faces.el (make-face): Remove deprecated optional argument. The
+       conditional application of X resources is handled directly by
+       make-face-x-resource-internal since Emacs 24.4.
+       (make-empty-face): Don't pass optional argument to make-face.
+
 2014-04-11  Glenn Morris  <address@hidden>
 
        * Makefile.in (EMACSDATA, EMACSDOC, EMACSPATH): Unexport.  (Bug#16429)

=== modified file 'lisp/faces.el'
--- a/lisp/faces.el     2014-04-07 20:54:16 +0000
+++ b/lisp/faces.el     2014-04-12 14:25:53 +0000
@@ -149,13 +149,11 @@
   "Return a list of all defined faces."
   (mapcar #'car face-new-frame-defaults))
 
-(defun make-face (face &optional no-init-from-resources)
+(defun make-face (face)
   "Define a new face with name FACE, a symbol.
 Do not call this directly from Lisp code; use `defface' instead.
 
-If NO-INIT-FROM-RESOURCES is non-nil, don't initialize face
-attributes from X resources.  If FACE is already known as a face,
-leave it unmodified.  Return FACE."
+If FACE is already known as a face, leave it unmodified.  Return FACE."
   (interactive (list (read-from-minibuffer
                      "Make face: " nil nil t 'face-name-history)))
   (unless (facep face)
@@ -166,8 +164,7 @@
     (when (fboundp 'facemenu-add-new-face)
       (facemenu-add-new-face face))
     ;; Define frame-local faces for all frames from X resources.
-    (unless no-init-from-resources
-      (make-face-x-resource-internal face)))
+    (make-face-x-resource-internal face))
   face)
 
 (defun make-empty-face (face)
@@ -175,7 +172,7 @@
 Do not call this directly from Lisp code; use `defface' instead."
   (interactive (list (read-from-minibuffer
                      "Make empty face: " nil nil t 'face-name-history)))
-  (make-face face 'no-init-from-resources))
+  (make-face face)
 
 (defun copy-face (old-face new-face &optional frame new-frame)
   "Define a face named NEW-FACE, which is a copy of OLD-FACE.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]