emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] trunk r114825: * configure.ac: It seems installing in non-


From: Glenn Morris
Subject: [Emacs-diffs] trunk r114825: * configure.ac: It seems installing in non-ASCII is not, in fact, ok.
Date: Sun, 27 Oct 2013 18:57:27 +0000
User-agent: Bazaar (2.6b2)

------------------------------------------------------------
revno: 114825
revision-id: address@hidden
parent: address@hidden
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Sun 2013-10-27 11:57:20 -0700
message:
  * configure.ac: It seems installing in non-ASCII is not, in fact, ok.
modified:
  ChangeLog                      changelog-20091113204419-o5vbwnq5f7feedwu-1538
  configure.ac                   
configure.in-20091113204419-o5vbwnq5f7feedwu-783
=== modified file 'ChangeLog'
--- a/ChangeLog 2013-10-25 02:22:13 +0000
+++ b/ChangeLog 2013-10-27 18:57:20 +0000
@@ -1,3 +1,7 @@
+2013-10-27  Glenn Morris  <address@hidden>
+
+       * configure.ac: It seems installing in non-ASCII is not, in fact, ok.
+
 2013-10-25  Glenn Morris  <address@hidden>
 
        * configure.ac: It seems _installing_ in non-ASCII is ok, not building.

=== modified file 'configure.ac'
--- a/configure.ac      2013-10-25 02:22:13 +0000
+++ b/configure.ac      2013-10-27 18:57:20 +0000
@@ -74,6 +74,11 @@
 AC_ARG_PROGRAM
 
 dnl http://debbugs.gnu.org/15260
+dnl I think we have to check, eg, both exec_prefix and bindir,
+dnl because the latter by default is not yet expanded, but the user
+dnl may have specified a value for it via --bindir.
+dnl At first glance, _installing_ in non-ASCII seems ok, but in fact
+dnl it is not; see http://debbugs.gnu.org/15260#61
 dnl Note that abs_srcdir and abs_builddir are not yet defined. :(
 
 dnl "`cd \"$srcdir\"`" is not portable.
@@ -82,11 +87,12 @@
 dnl double-quoted back-quoted expressions (pfew!)."
 temp_srcdir=`cd "$srcdir"; pwd`
 
-for var in "`pwd`" "$temp_srcdir"; do
+for var in "`pwd`" "$temp_srcdir" "$prefix" "$exec_prefix" \
+    "$datarootdir" "$bindir" "$datadir" "$sharedstatedir" "$libexecdir"; do
 
   dnl configure sets LC_ALL=C early on, so this range should work.
   case "$var" in
-    *[[^\ -~]]*) AC_MSG_ERROR([Emacs cannot be built in a directory whose name 
contains non-ASCII characters: $var]) ;;
+    *[[^\ -~]]*) AC_MSG_ERROR([Emacs cannot be built or installed in a 
directory whose name contains non-ASCII characters: $var]) ;;
   esac
 
 done


reply via email to

[Prev in Thread] Current Thread [Next in Thread]