[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] trunk r114118: * lisp/net/tramp.el (with-parsed-tramp-file
From: |
Stefan Monnier |
Subject: |
[Emacs-diffs] trunk r114118: * lisp/net/tramp.el (with-parsed-tramp-file-name): Silence compiler |
Date: |
Tue, 03 Sep 2013 16:23:29 +0000 |
User-agent: |
Bazaar (2.6b2) |
------------------------------------------------------------
revno: 114118
revision-id: address@hidden
parent: address@hidden
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Tue 2013-09-03 12:23:10 -0400
message:
* lisp/net/tramp.el (with-parsed-tramp-file-name): Silence compiler
warnings, and factor our common code.
modified:
lisp/ChangeLog changelog-20091113204419-o5vbwnq5f7feedwu-1432
lisp/net/tramp-compat.el
trampcompat.el-20091113204419-o5vbwnq5f7feedwu-7298
lisp/net/tramp.el tramp.el-20091113204419-o5vbwnq5f7feedwu-2427
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog 2013-09-03 00:29:10 +0000
+++ b/lisp/ChangeLog 2013-09-03 16:23:10 +0000
@@ -1,3 +1,8 @@
+2013-09-03 Stefan Monnier <address@hidden>
+
+ * net/tramp.el (with-parsed-tramp-file-name): Silence compiler
+ warnings, and factor our common code.
+
2013-09-03 Dmitry Gutov <address@hidden>
* progmodes/ruby-mode.el (ruby-calculate-indent): Consider
@@ -7,8 +12,8 @@
2013-09-02 Fabián Ezequiel Gallina <address@hidden>
Format code sent to Python shell for robustness.
- * progmodes/python.el (python-shell-buffer-substring): New
- function.
+ * progmodes/python.el (python-shell-buffer-substring):
+ New function.
(python-shell-send-region, python-shell-send-buffer): Use it.
2013-09-02 Michael Albinus <address@hidden>
=== modified file 'lisp/net/tramp-compat.el'
--- a/lisp/net/tramp-compat.el 2013-09-02 13:41:08 +0000
+++ b/lisp/net/tramp-compat.el 2013-09-03 16:23:10 +0000
@@ -186,7 +186,7 @@
;; `with-temp-message' does not exist in XEmacs.
(if (fboundp 'with-temp-message)
(defalias 'tramp-compat-with-temp-message 'with-temp-message)
- (defmacro tramp-compat-with-temp-message (message &rest body)
+ (defmacro tramp-compat-with-temp-message (_message &rest body)
"Display MESSAGE temporarily if non-nil while BODY is evaluated."
`(progn ,@body)))
=== modified file 'lisp/net/tramp.el'
--- a/lisp/net/tramp.el 2013-09-02 13:41:08 +0000
+++ b/lisp/net/tramp.el 2013-09-03 16:23:10 +0000
@@ -1632,18 +1632,19 @@
If VAR is nil, then we bind `v' to the structure and `method', `user',
`host', `localname', `hop' to the components."
- `(let* ((,(or var 'v) (tramp-dissect-file-name ,filename))
- (,(if var (intern (concat (symbol-name var) "-method")) 'method)
- (tramp-file-name-method ,(or var 'v)))
- (,(if var (intern (concat (symbol-name var) "-user")) 'user)
- (tramp-file-name-user ,(or var 'v)))
- (,(if var (intern (concat (symbol-name var) "-host")) 'host)
- (tramp-file-name-host ,(or var 'v)))
- (,(if var (intern (concat (symbol-name var) "-localname")) 'localname)
- (tramp-file-name-localname ,(or var 'v)))
- (,(if var (intern (concat (symbol-name var) "-hop")) 'hop)
- (tramp-file-name-hop ,(or var 'v))))
- ,@body))
+ (let ((bindings
+ (mapcar (lambda (elem)
+ `(,(if var (intern (format "%s-%s" var elem)) elem)
+ (,(intern (format "tramp-file-name-%s" elem))
+ ,(or var 'v))))
+ '(method user host localname hop))))
+ `(let* ((,(or var 'v) (tramp-dissect-file-name ,filename))
+ ,@bindings)
+ ;; We don't know which of those vars will be used, so we bind them all,
+ ;; and then add here a dummy use of all those variables, so we don't get
+ ;; flooded by warnings about those vars `body' didn't use.
+ (ignore ,@(mapcar #'car bindings))
+ ,@body)))
(put 'with-parsed-tramp-file-name 'lisp-indent-function 2)
(put 'with-parsed-tramp-file-name 'edebug-form-spec '(form symbolp body))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] trunk r114118: * lisp/net/tramp.el (with-parsed-tramp-file-name): Silence compiler,
Stefan Monnier <=