emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r111061: Fix for bad test in ruby-mod


From: Chong Yidong
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r111061: Fix for bad test in ruby-mode-tests.el.
Date: Sun, 02 Dec 2012 14:06:32 +0800
User-agent: Bazaar (2.5.0)

------------------------------------------------------------
revno: 111061
committer: Chong Yidong <address@hidden>
branch nick: trunk
timestamp: Sun 2012-12-02 14:06:32 +0800
message:
  Fix for bad test in ruby-mode-tests.el.
  
  * automated/ruby-mode-tests.el (ruby-add-log-current-method-examples):
  Don't use loop macro, to allow automated testing to work.
modified:
  test/ChangeLog
  test/automated/ruby-mode-tests.el
=== modified file 'test/ChangeLog'
--- a/test/ChangeLog    2012-11-20 04:24:09 +0000
+++ b/test/ChangeLog    2012-12-02 06:06:32 +0000
@@ -1,3 +1,9 @@
+2012-12-02  Chong Yidong  <address@hidden>
+
+       * automated/ruby-mode-tests.el
+       (ruby-add-log-current-method-examples): Don't use loop macro, to
+       allow automated testing to work.
+
 2012-11-20  Stefan Monnier  <address@hidden>
 
        * automated/advice-tests.el (advice-tests--data): Remove.

=== modified file 'test/automated/ruby-mode-tests.el'
--- a/test/automated/ruby-mode-tests.el 2012-11-14 12:17:21 +0000
+++ b/test/automated/ruby-mode-tests.el 2012-12-02 06:06:32 +0000
@@ -296,21 +296,23 @@
   (let ((pairs '(("foo" . "#foo")
                  ("C.foo" . ".foo")
                  ("self.foo" . ".foo"))))
-    (loop for (name . value) in pairs
-          do (with-temp-buffer
-               (insert (ruby-test-string
-                        "module M
+    (dolist (pair pairs)
+      (let ((name  (car pair))
+           (value (cdr pair)))
+       (with-temp-buffer
+         (insert (ruby-test-string
+                  "module M
                         |  class C
                         |    def %s
                         |    end
                         |  end
                         |end"
-                        name))
-               (ruby-mode)
-               (search-backward "def")
-               (forward-line)
-               (should (string= (ruby-add-log-current-method)
-                                (format "M::C%s" value)))))))
+                  name))
+         (ruby-mode)
+         (search-backward "def")
+         (forward-line)
+         (should (string= (ruby-add-log-current-method)
+                          (format "M::C%s" value))))))))
 
 (defvar ruby-block-test-example
   (ruby-test-string


reply via email to

[Prev in Thread] Current Thread [Next in Thread]