[Emacs-diffs] /srv/bzr/emacs/trunk r110783: Omit duplicate definitions no longer needed with gcc -g3.

[Paul Eggert]

------------------------------------------------------------
revno: 110783
committer: Paul Eggert <address@hidden>
branch nick: trunk
timestamp: Sat 2012-11-03 11:19:50 -0700
message:
  Omit duplicate definitions no longer needed with gcc -g3.
  
  * lisp.h (GCTYPEBITS, GCALIGNMENT, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG)
  (VALMASK, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM):
  Define only as macros.  There's no longer any need to also define
  these symbols as enums or as constants, since we now assume
  gcc -g3 when debugging.
modified:
  src/ChangeLog
  src/lisp.h

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2012-11-03 16:36:23 +0000
+++ b/src/ChangeLog     2012-11-03 18:19:50 +0000
@@ -1,3 +1,12 @@
+2012-11-03  Paul Eggert  <address@hidden>
+
+       Omit duplicate definitions no longer needed with gcc -g3.
+       * lisp.h (GCTYPEBITS, GCALIGNMENT, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG)
+       (VALMASK, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM):
+       Define only as macros.  There's no longer any need to also define
+       these symbols as enums or as constants, since we now assume
+       gcc -g3 when debugging.
+
 2012-11-03  Chong Yidong  <address@hidden>
 
        * process.c (wait_reading_process_output): Clean up the last

=== modified file 'src/lisp.h'
--- a/src/lisp.h        2012-11-02 10:34:26 +0000
+++ b/src/lisp.h        2012-11-03 18:19:50 +0000
@@ -152,20 +152,15 @@
    on the few static Lisp_Objects used: all the defsubr as well
    as the two special buffers buffer_defaults and buffer_local_symbols.  */
 
-enum Lisp_Bits
-  {
-    /* Number of bits in a Lisp_Object tag.  This can be used in #if,
-       and for GDB's sake also as a regular symbol.  */
-    GCTYPEBITS =
+/* Number of bits in a Lisp_Object tag.  This can be used in #if.  */
 #define GCTYPEBITS 3
-       GCTYPEBITS,
 
-    /* 2**GCTYPEBITS.  This must also be a macro that expands to a
-       literal integer constant, for MSVC.  */
-    GCALIGNMENT =
+/* 2**GCTYPEBITS.  This must be a macro that expands to a literal
+   integer constant, for MSVC.  */
 #define GCALIGNMENT 8
-       GCALIGNMENT,
 
+enum Lisp_Bits
+  {
     /* Number of bits in a Lisp_Object value, not counting the tag.  */
     VALBITS = BITS_PER_EMACS_INT - GCTYPEBITS,
 
@@ -383,15 +378,11 @@
 
 /* In the size word of a vector, this bit means the vector has been marked.  */
 
-static ptrdiff_t const ARRAY_MARK_FLAG
 #define ARRAY_MARK_FLAG PTRDIFF_MIN
-      = ARRAY_MARK_FLAG;
 
 /* In the size word of a struct Lisp_Vector, this bit means it's really
    some other vector-like object.  */
-static ptrdiff_t const PSEUDOVECTOR_FLAG
 #define PSEUDOVECTOR_FLAG (PTRDIFF_MAX - PTRDIFF_MAX / 2)
-      = PSEUDOVECTOR_FLAG;
 
 /* In a pseudovector, the size field actually contains a word with one
    PSEUDOVECTOR_FLAG bit set, and one of the following values extracted
@@ -473,9 +464,7 @@
 
 #else  /* not USE_LSB_TAG */
 
-static EMACS_INT const VALMASK
 #define VALMASK VAL_MAX
-      = VALMASK;
 
 #define XTYPE(a) ((enum Lisp_Type) ((EMACS_UINT) XLI (a) >> VALBITS))
 
@@ -523,14 +512,9 @@
 #define EQ(x, y) (XHASH (x) == XHASH (y))
 
 /* Largest and smallest representable fixnum values.  These are the C
-   values.  They are macros for use in static initializers, and
-   constants for visibility to GDB.  */
-static EMACS_INT const MOST_POSITIVE_FIXNUM =
+   values.  They are macros for use in static initializers.  */
 #define MOST_POSITIVE_FIXNUM (EMACS_INT_MAX >> INTTYPEBITS)
-       MOST_POSITIVE_FIXNUM;
-static EMACS_INT const MOST_NEGATIVE_FIXNUM =
 #define MOST_NEGATIVE_FIXNUM (-1 - MOST_POSITIVE_FIXNUM)
-       MOST_NEGATIVE_FIXNUM;
 
 /* Value is non-zero if I doesn't fit into a Lisp fixnum.  It is
    written this way so that it also works if I is of unsigned