[Emacs-diffs] /srv/bzr/emacs/emacs-24 r107850: * lisp/vc/vc-annotate.el (vc-annotate-show-diff-revision-at-line-internal):

[Stefan Monnier]

------------------------------------------------------------
revno: 107850
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Tue 2012-04-10 16:08:43 -0400
message:
  * lisp/vc/vc-annotate.el (vc-annotate-show-diff-revision-at-line-internal):
  Use derived-mode-p.  Run the diff asynchronously.
modified:
  lisp/ChangeLog
  lisp/vc/vc-annotate.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-04-10 17:09:34 +0000
+++ b/lisp/ChangeLog    2012-04-10 20:08:43 +0000
@@ -1,3 +1,8 @@
+2012-04-10  Stefan Monnier  <address@hidden>
+
+       * vc/vc-annotate.el (vc-annotate-show-diff-revision-at-line-internal):
+       Use derived-mode-p.  Run the diff asynchronously.
+
 2012-04-10  Lars Magne Ingebrigtsen  <address@hidden>
 
        * obsolete/mouse-sel.el: Add an Obsolete-since header.
@@ -10,13 +15,13 @@
 
 2012-04-10  Nathan Weizenbaum  <address@hidden>
 
-       * progmodes/python.el (python-fill-paragraph): Make
-       python-fill-region in a multiline string work when font-lock is
+       * progmodes/python.el (python-fill-paragraph):
+       Make python-fill-region in a multiline string work when font-lock is
        disabled (bug#7018).
 
 2012-04-10  Laimonas Vėbra  <address@hidden>  (tiny change)
 
-       * language/european.el (cp775): Added oem/legacy (en)coding on
+       * language/european.el (cp775): Add oem/legacy (en)coding on
        DOS/MS Windows for the Baltic languages. There are still plenty of
        texts written in this encoding/codepage (bug#6519).
 
@@ -27,7 +32,7 @@
 
 2012-04-10  Florian Adamsky  <address@hidden>  (tiny change)
 
-       * recentf.el (recentf-dialog-mode-map): Added two keybindings for
+       * recentf.el (recentf-dialog-mode-map): Add two keybindings for
        next-line "n" and previous-line "p" in order to make recentf more
        consistent with ibuffer, dired or org-mode (bug#9387).
 

=== modified file 'lisp/vc/vc-annotate.el'
--- a/lisp/vc/vc-annotate.el    2012-01-19 07:21:25 +0000
+++ b/lisp/vc/vc-annotate.el    2012-04-10 20:08:43 +0000
@@ -522,12 +522,12 @@
             (car rev-at-line) t 1)))))))
 
 (defun vc-annotate-show-diff-revision-at-line-internal (filediff)
-  (if (not (equal major-mode 'vc-annotate-mode))
+  (if (not (derived-mode-p 'vc-annotate-mode))
       (message "Cannot be invoked outside of a vc annotate buffer")
     (let* ((rev-at-line (vc-annotate-extract-revision-at-line))
-         (prev-rev nil)
-         (rev (car rev-at-line))
-         (fname (cdr rev-at-line)))
+           (prev-rev nil)
+           (rev (car rev-at-line))
+           (fname (cdr rev-at-line)))
       (if (not rev-at-line)
          (message "Cannot extract revision number from the current line")
        (setq prev-rev
@@ -535,17 +535,15 @@
                                (if filediff fname nil) rev))
        (if (not prev-rev)
            (message "Cannot diff from any revision prior to %s" rev)
-         (save-window-excursion
-           (vc-diff-internal
-            nil
-            ;; The value passed here should follow what
-            ;; `vc-deduce-fileset' returns.
-            (list vc-annotate-backend
-                  (if filediff
-                      (list fname)
-                    nil))
-            prev-rev rev))
-         (switch-to-buffer "*vc-diff*"))))))
+          (vc-diff-internal
+           t
+           ;; The value passed here should follow what
+           ;; `vc-deduce-fileset' returns.
+           (list vc-annotate-backend
+                 (if filediff
+                     (list fname)
+                   nil))
+           prev-rev rev))))))
 
 (defun vc-annotate-show-diff-revision-at-line ()
   "Visit the diff of the revision at line from its previous revision."