emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r108621: Added and corrected some com


From: Stefan Merten
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r108621: Added and corrected some comments.
Date: Sat, 16 Jun 2012 11:33:58 +0200
User-agent: Bazaar (2.5.0)

------------------------------------------------------------
revno: 108621
committer: Stefan Merten <address@hidden>
branch nick: trunk
timestamp: Sat 2012-06-16 11:33:58 +0200
message:
  Added and corrected some comments.
  (rst-re-alist-def): Improve symbol syntax.
  (rst-mode-syntax-table): Correct syntax entries.
modified:
  lisp/ChangeLog
  lisp/textmodes/rst.el
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-06-15 21:47:39 +0000
+++ b/lisp/ChangeLog    2012-06-16 09:33:58 +0000
@@ -1,3 +1,9 @@
+2012-06-16  Stefan Merten  <address@hidden>
+
+       * textmodes/rst.el: Added and corrected some comments.
+       (rst-re-alist-def): Improve symbol syntax.
+       (rst-mode-syntax-table): Correct syntax entries.
+
 2012-06-15  Juanma Barranquero  <address@hidden>
 
        * makefile.w32-in (COMPILE_FIRST): Synch with makefile.in changes

=== modified file 'lisp/textmodes/rst.el'
--- a/lisp/textmodes/rst.el     2012-06-07 09:20:41 +0000
+++ b/lisp/textmodes/rst.el     2012-06-16 09:33:58 +0000
@@ -103,6 +103,9 @@
 
 ;;; Code:
 
+;; FIXME: When 24.1 is common place remove use of `lexical-let' and put "-*-
+;;        lexical-binding: t -*-" in the first line.
+
 ;; Only use of macros is allowed - may be replaced by `cl-lib' some time.
 (eval-when-compile
   (require 'cl))
@@ -150,10 +153,7 @@
                                 (equal elem e)))
                     seq)))
 
-;; FIXME: Check whether complicated `defconst's can be embedded in
-;;        `eval-when-compile'.
-
-;; FIXME: Check whether `lambda's can be embedded in `function'.
+;; FIXME: Embed complicated `defconst's in `eval-when-compile'.
 
 
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;; Versions
@@ -171,7 +171,7 @@
 ;; Use CVSHeader to really get information from CVS and not other version
 ;; control systems.
 (defconst rst-cvs-header
-  "$CVSHeader: sm/rst_el/rst.el,v 1.282 2012-06-06 19:16:55 stefan Exp $")
+  "$CVSHeader: sm/rst_el/rst.el,v 1.285 2012-06-11 20:38:23 stefan Exp $")
 (defconst rst-cvs-rev
   (rst-extract-version "\\$" "CVSHeader: \\S + " "[0-9]+\\(?:\\.[0-9]+\\)+"
                       " .*" rst-cvs-header "0.0")
@@ -203,7 +203,6 @@
                       "%Revision: 1.256 %")
   "CVS revision of this file in the official version.")
 
-;; FIXME: Version differences due to SVN checkin must not change this.
 (defconst rst-version
   (if (equal rst-official-cvs-rev rst-cvs-rev)
       rst-official-version
@@ -412,7 +411,8 @@
                                       ; tag.
 
     ;; Symbol (`sym')
-    (sym-tag (:shy "\\sw+" (:shy "\\s_\\sw+") "*"))
+    (sym-prt "[-+.:_]") ; Non-word part of a symbol.
+    (sym-tag (:shy "\\sw+" (:shy sym-prt "\\sw+") "*"))
 
     ;; URIs (`uri')
     (uri-tag (:alt ,@rst-uri-schemes))
@@ -599,6 +599,7 @@
                    ;; Same as mark-defun sgml-mark-current-element.
                    [?\C-c ?\C-m])
     ;; Move backward/forward between section titles.
+    ;; FIXME: Also bind similar to outline mode.
     (rst-define-key map [?\C-\M-a] 'rst-backward-section
                    ;; Same as beginning-of-defun.
                    [?\C-c ?\C-n])
@@ -696,23 +697,20 @@
 ;; Syntax table.
 (defvar rst-mode-syntax-table
   (let ((st (copy-syntax-table text-mode-syntax-table)))
-    ;; FIXME: This must be rethought; at the very least ?. should not be a
-    ;;        symbol for `dabbrev' to work properly.
     (modify-syntax-entry ?$ "." st)
     (modify-syntax-entry ?% "." st)
     (modify-syntax-entry ?& "." st)
     (modify-syntax-entry ?' "." st)
     (modify-syntax-entry ?* "." st)
-    (modify-syntax-entry ?+ "_" st)
-    (modify-syntax-entry ?. "_" st)
+    (modify-syntax-entry ?+ "." st)
+    (modify-syntax-entry ?- "." st)
     (modify-syntax-entry ?/ "." st)
-    (modify-syntax-entry ?: "_" st)
     (modify-syntax-entry ?< "." st)
     (modify-syntax-entry ?= "." st)
     (modify-syntax-entry ?> "." st)
     (modify-syntax-entry ?\\ "\\" st)
+    (modify-syntax-entry ?_ "." st)
     (modify-syntax-entry ?| "." st)
-    (modify-syntax-entry ?_ "_" st)
     (modify-syntax-entry ?\u00ab "." st)
     (modify-syntax-entry ?\u00bb "." st)
     (modify-syntax-entry ?\u2018 "." st)
@@ -1816,7 +1814,7 @@
        ;; Apply the new style.
        (apply 'rst-update-section (nth (car lm) rst-preferred-adornments))
 
-       ;; Reset the market to avoid slowing down editing until it gets GC'ed.
+       ;; Reset the marker to avoid slowing down editing until it gets GC'ed.
        (set-marker (cdr lm) nil)
        )
     )))


reply via email to

[Prev in Thread] Current Thread [Next in Thread]