[Emacs-diffs] /srv/bzr/emacs/trunk r104098: * lisp/minibuffer.el (completion--message): New function.

[Stefan Monnier]

------------------------------------------------------------
revno: 104098
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Tue 2011-05-03 22:19:32 -0300
message:
  * lisp/minibuffer.el (completion--message): New function.
  (completion--do-completion, minibuffer-complete)
  (minibuffer-force-complete, minibuffer-complete-word): Use it.
  (completion--do-completion): Don't ignore completion-auto-help when in
  icomplete-mode.
modified:
  lisp/ChangeLog
  lisp/minibuffer.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2011-05-04 01:02:09 +0000
+++ b/lisp/ChangeLog    2011-05-04 01:19:32 +0000
@@ -1,5 +1,11 @@
 2011-05-04  Stefan Monnier  <address@hidden>
 
+       * minibuffer.el (completion--message): New function.
+       (completion--do-completion, minibuffer-complete)
+       (minibuffer-force-complete, minibuffer-complete-word): Use it.
+       (completion--do-completion): Don't ignore completion-auto-help when in
+       icomplete-mode.
+
        * whitespace.el (whitespace-trailing-regexp): Don't rely on the
        internal encoding (e.g. tibetan zero is not whitespace).
        (global-whitespace-mode): Prefer save-current-buffer.

=== modified file 'lisp/minibuffer.el'
--- a/lisp/minibuffer.el        2011-04-28 15:32:28 +0000
+++ b/lisp/minibuffer.el        2011-05-04 01:19:32 +0000
@@ -558,6 +558,10 @@
 (defvar completion-fail-discreetly nil
   "If non-nil, stay quiet when there  is no match.")
 
+(defun completion--message (msg)
+  (if completion-show-inline-help
+      (minibuffer-message msg)))
+
 (defun completion--do-completion (&optional try-completion-function)
   "Do the completion and return a summary of what happened.
 M = completion was performed, the text was Modified.
@@ -585,9 +589,9 @@
     (cond
      ((null comp)
       (minibuffer-hide-completions)
-      (when (and (not completion-fail-discreetly) completion-show-inline-help)
+      (unless completion-fail-discreetly
        (ding)
-       (minibuffer-message "No match"))
+       (completion--message "No match"))
       (minibuffer--bitset nil nil nil))
      ((eq t comp)
       (minibuffer-hide-completions)
@@ -657,15 +661,13 @@
               (minibuffer-hide-completions))
              ;; Show the completion table, if requested.
              ((not exact)
-             (if (cond (icomplete-mode t)
-                       ((null completion-show-inline-help) t)
-                       ((eq completion-auto-help 'lazy)
-                        (eq this-command last-command))
-                       (t completion-auto-help))
+             (if (case completion-auto-help
+                    (lazy (eq this-command last-command))
+                    (t completion-auto-help))
                   (minibuffer-completion-help)
-                (minibuffer-message "Next char not unique")))
+                (completion--message "Next char not unique")))
              ;; If the last exact completion and this one were the same, it
-             ;; means we've already given a "Next char not unique" message
+             ;; means we've already given a "Complete, but not unique" message
              ;; and the user's hit TAB again, so now we give him help.
              ((eq this-command last-command)
               (if completion-auto-help (minibuffer-completion-help))))
@@ -703,11 +705,9 @@
     t)
    (t (case (completion--do-completion)
         (#b000 nil)
-        (#b001 (if completion-show-inline-help
-                  (minibuffer-message "Sole completion"))
+        (#b001 (completion--message "Sole completion")
                t)
-        (#b011 (if completion-show-inline-help
-                  (minibuffer-message "Complete, but not unique"))
+        (#b011 (completion--message "Complete, but not unique")
                t)
         (t     t)))))
 
@@ -765,9 +765,8 @@
          (end (field-end))
          (all (completion-all-sorted-completions)))
     (if (not (consp all))
-       (if completion-show-inline-help
-           (minibuffer-message
-            (if all "No more completions" "No completions")))
+        (completion--message
+         (if all "No more completions" "No completions"))
       (setq completion-cycling t)
       (goto-char end)
       (insert (car all))
@@ -955,11 +954,9 @@
   (interactive)
   (case (completion--do-completion 'completion--try-word-completion)
     (#b000 nil)
-    (#b001 (if completion-show-inline-help
-              (minibuffer-message "Sole completion"))
+    (#b001 (completion--message "Sole completion")
            t)
-    (#b011 (if completion-show-inline-help
-              (minibuffer-message "Complete, but not unique"))
+    (#b011 (completion--message "Complete, but not unique")
            t)
     (t     t)))