[Emacs-diffs] /srv/bzr/emacs/emacs-23 r99930: * gtkutil.c (xg_event_is_for_menubar): Also check that event window

[Jan D]

------------------------------------------------------------
revno: 99930
committer: Jan D <address@hidden>
branch nick: emacs-23
timestamp: Sat 2010-07-17 11:59:19 +0200
message:
  * gtkutil.c (xg_event_is_for_menubar): Also check that event window
  is related to the menu bar (Bug#6499).
modified:
  src/ChangeLog
  src/gtkutil.c

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2010-07-14 10:05:53 +0000
+++ b/src/ChangeLog     2010-07-17 09:59:19 +0000
@@ -1,3 +1,8 @@
+2010-07-17  Jan Djärv  <address@hidden>
+
+       * gtkutil.c (xg_event_is_for_menubar): Also check that event window
+       is related to the menu bar (Bug#6499).
+
 2010-07-14  Jan Djärv  <address@hidden>
 
        * xterm.h (x_menubar_window_to_frame): Second parameter is XEvent*.

=== modified file 'src/gtkutil.c'
--- a/src/gtkutil.c     2010-07-14 10:05:53 +0000
+++ b/src/gtkutil.c     2010-07-17 09:59:19 +0000
@@ -2994,6 +2994,13 @@
 xg_event_is_for_menubar (FRAME_PTR f, XEvent *event)
 {
   struct x_output *x = f->output_data.x;
+  GList *iter;
+  GdkRectangle rec;
+  GList *list;
+  GdkDisplay *gdpy;
+  GdkWindow *gw;
+  GdkEvent gevent;
+  GtkWidget *gwdesc;
 
   if (! x->menubar_widget) return 0;
 
@@ -3004,14 +3011,24 @@
          && event->xbutton.same_screen))
     return 0;
 
-  GList *list = gtk_container_get_children (GTK_CONTAINER (x->menubar_widget));
+  gdpy = gdk_x11_lookup_xdisplay (FRAME_X_DISPLAY (f));
+  gw = gdk_xid_table_lookup_for_display (gdpy, event->xbutton.window);
+  if (! gw) return 0;
+  gevent.any.window = gw;
+  gwdesc = gtk_get_event_widget (&gevent);
+  if (! gwdesc) return 0;
+  if (! GTK_IS_MENU_BAR (gwdesc)
+      && ! GTK_IS_MENU_ITEM (gwdesc)
+      && ! gtk_widget_is_ancestor (x->menubar_widget, gwdesc))
+    return 0;
+
+  list = gtk_container_get_children (GTK_CONTAINER (x->menubar_widget));
   if (! list) return 0;
-  GList *iter;
-  GdkRectangle rec;
   rec.x = event->xbutton.x;
   rec.y = event->xbutton.y;
   rec.width = 1;
   rec.height = 1;
+
   for (iter = list ; iter; iter = g_list_next (iter))
     {
       GtkWidget *w = GTK_WIDGET (iter->data);