[Emacs-diffs] /srv/bzr/emacs/trunk r100518: * net/rcirc.el (rcirc-sort-nicknames): Change default.

[Stefan Monnier]

------------------------------------------------------------
revno: 100518
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Thu 2010-06-03 11:51:38 -0400
message:
  * net/rcirc.el (rcirc-sort-nicknames): Change default.
  (rcirc-sort-nicknames-join): Avoid setq.
modified:
  lisp/ChangeLog
  lisp/net/rcirc.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2010-06-03 15:07:49 +0000
+++ b/lisp/ChangeLog    2010-06-03 15:51:38 +0000
@@ -1,3 +1,8 @@
+2010-06-03  Stefan Monnier  <address@hidden>
+
+       * net/rcirc.el (rcirc-sort-nicknames): Change default.
+       (rcirc-sort-nicknames-join): Avoid setq.
+
 2010-06-03  Deniz Dogan  <address@hidden>
 
        * net/rcirc.el (rcirc-sort-nicknames): New custom.

=== modified file 'lisp/net/rcirc.el'
--- a/lisp/net/rcirc.el 2010-06-03 15:07:49 +0000
+++ b/lisp/net/rcirc.el 2010-06-03 15:51:38 +0000
@@ -281,7 +281,8 @@
   :type 'hook
   :group 'rcirc)
 
-(defcustom rcirc-sort-nicknames nil
+;; Does this really merit a config variable?
+(defcustom rcirc-sort-nicknames t
   "If non-nil, sorts nickname listings."
   :type 'boolean
   :group 'rcirc)
@@ -1682,10 +1683,9 @@
 INPUT is a string containing nicknames separated by SEP.
 
 This function is non-destructive, sorting a copy of the input."
-  (let ((parts (split-string input sep t))
-        copy)
-    (setq copy (sort parts 'rcirc-nickname<))
-    (mapconcat 'identity copy sep)))
+  (let* ((parts (split-string input sep t))
+         (sorted (sort parts 'rcirc-nickname<)))
+    (mapconcat 'identity sorted sep)))
 
 ;;; activity tracking
 (defvar rcirc-track-minor-mode-map (make-sparse-keymap)