[Emacs-diffs] emacs/lisp ChangeLog play/bubbles.el

[Juanma Barranquero]

CVSROOT:        /cvsroot/emacs
Module name:    emacs
Changes by:     Juanma Barranquero <lektu>      08/11/25 02:02:01

Modified files:
        lisp           : ChangeLog 
        lisp/play      : bubbles.el 

Log message:
        * play/bubbles.el (bubbles-mode): Define with `define-derived-mode'.
          (bubbles-shift-mode, bubbles--update-score): Fix typos in docstrings.
          (bubbles--empty-char): Use "\s".

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.14859&r2=1.14860
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/play/bubbles.el?cvsroot=emacs&r1=1.9&r2=1.10

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.14859
retrieving revision 1.14860
diff -u -b -r1.14859 -r1.14860
--- ChangeLog   25 Nov 2008 01:30:22 -0000      1.14859
+++ ChangeLog   25 Nov 2008 02:01:58 -0000      1.14860
@@ -1,3 +1,9 @@
+2008-11-25  Juanma Barranquero  <address@hidden>
+
+       * play/bubbles.el (bubbles-mode): Define with `define-derived-mode'.
+       (bubbles-shift-mode, bubbles--update-score): Fix typos in docstrings.
+       (bubbles--empty-char): Use "\s".
+
 2008-11-25  Jay Belanger  <address@hidden>
 
        * calc/calc.el (calc-settings-file, calc-language-alist)
@@ -14939,7 +14945,6 @@
        standard-display-table.
        (latin1-display-identities): Adjust for the change of what is
        returned by (get-language-info charset 'charset).
-
        * international/mule-util.el (char-displayable-p): Fix for Latin-1
        characters and terminal case.
 

Index: play/bubbles.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/play/bubbles.el,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- play/bubbles.el     1 Jul 2008 03:04:39 -0000       1.9
+++ play/bubbles.el     25 Nov 2008 02:02:01 -0000      1.10
@@ -209,7 +209,7 @@
 (defcustom bubbles-shift-mode
   'default
   "Shift mode.
-Available modes are `shift-default' and`shift-always'."
+Available modes are `shift-default' and `shift-always'."
   :type '(radio (const :tag "Default" default)
                 (const :tag "Shifter" always)
                 ;;(const :tag "Mega Shifter" 'mega)
@@ -782,7 +782,7 @@
 
 (defsubst bubbles--empty-char ()
   "The character used for removed bubbles (empty grid cells)."
-  ? )
+  ?\s)
 
 (defun bubbles-set-graphics-theme-ascii ()
   "Set graphics theme to `ascii'."
@@ -918,20 +918,14 @@
     map)
   "Mode map for bubbles.")
 
-(defun bubbles-mode ()
+(define-derived-mode bubbles-mode nil "Bubbles"
   "Major mode for playing bubbles.
 \\{bubbles-mode-map}"
-  (kill-all-local-variables)
-  (use-local-map bubbles-mode-map)
-  (setq major-mode 'bubbles-mode)
-  (setq mode-name "Bubbles")
   (setq buffer-read-only t)
   (buffer-disable-undo)
-  (setq buffer-undo-list t)
   (force-mode-line-update)
   (redisplay)
-  (add-hook 'post-command-hook 'bubbles--mark-neighbourhood t t)
-  (run-hooks 'bubbles-mode-hook))
+  (add-hook 'post-command-hook 'bubbles--mark-neighbourhood t t))
 
 ;;;###autoload
 (defun bubbles ()
@@ -1154,7 +1148,7 @@
   (bubbles--update-score))
 
 (defun bubbles--update-score ()
-  "Calculate and display new bubble score."
+  "Calculate and display new bubbles score."
   (setq bubbles--score (+ bubbles--score bubbles--neighbourhood-score))
   (bubbles--show-scores))