[Emacs-diffs] Changes to emacs/lisp/emacs-lisp/bytecomp.el,v

[Glenn Morris]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Glenn Morris <gm>       08/03/01 20:07:28

Index: bytecomp.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/emacs-lisp/bytecomp.el,v
retrieving revision 2.230
retrieving revision 2.231
diff -u -b -r2.230 -r2.231
--- bytecomp.el 12 Feb 2008 11:21:31 -0000      2.230
+++ bytecomp.el 1 Mar 2008 20:07:28 -0000       2.231
@@ -3562,10 +3562,16 @@
          ;; emacs/xemacs tests have been optimized away, so this is
          ;; not doing anything useful here, is should probably be
          ;; moved to a different place.
-         ;; (byte-compile-warnings
-         ;;  (if (member ,condition '((featurep 'xemacs)
-         ;;                        (not (featurep 'emacs))))
-         ;;      nil byte-compile-warnings))
+         ;; It is doing _something_. If this is commented out, then
+         ;; compiling a file which requires another file which
+         ;; defines a defsubst that uses (featurep 'xemacs) results
+         ;; in a spurious compilation warning about the xemacs code. Eg:
+         ;; (defsubst foo () (if (featurep 'xemacs) (setq foo t)))
+         ;; where foo is a free variable.
+         (byte-compile-warnings
+          (if (member ,condition '((featurep 'xemacs)
+                                   (not (featurep 'emacs))))
+              nil byte-compile-warnings))
          )
      (unwind-protect
         (progn ,@body)