[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Removing the usage of X structures (or their names) in independent c
|
From: |
Eli Zaretskii |
|
Subject: |
Re: Removing the usage of X structures (or their names) in independent code |
|
Date: |
Mon, 13 May 2019 20:40:42 +0300 |
> From: Alex Gramiak <address@hidden>
> Cc: address@hidden
> Date: Mon, 13 May 2019 10:15:53 -0600
>
> Alex Gramiak <address@hidden> writes:
>
> > I posted a patch series to the scratch/X_Typedefs branch. WDYT?
> >
> > The first few patches are straightforward, but the XChar2b patch is a
> > bit more involved.
> >
> > Regarding the last patch, I don't like the names Emacs_Pix_Container
> > (XImagePtr) and Emacs_Pix_Context (XImagePtr_or_DC), but I'm lost as to
> > better names.
> >
> > AFAIU XImage is a client-side structure holding bitmap/pixmap data[1].
> > My first thought was "Emacs_Pixmap_Container", but that would be easily
> > confused for a container for Emacs_Pixmap. At least the abbreviation
> > dissociates the two structures a bit.
> >
> > [1] https://tronche.com/gui/x/xlib/graphics/images.html
>
> Ping. Any comments? I'd like to merge this branch to master.
Sorry, I was busy and haven't yet time to review the patches.
Hopefully tomorrow.