emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unit tests and lexical-binding for delim-col.el


From: Stefan Kangas
Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el
Date: Sat, 11 May 2019 12:46:43 +0200

Basil L. Contovounesios <address@hidden> writes:
> if no-one objects within the next few days, I or someone else will push the
> patch to master.

Great.

> I noticed an additional possible cleanup:

I've included these cleanups in the attached patch.

Could we also get rid of this comment?  I don't see how it helps since this
has been in vanilla for 20 years now.

;; To use it, make sure that this file is in load-path and insert in your
;; .emacs:
;;
;;    (require 'delim-col)

Stefan Monnier <address@hidden> writes:
> BTW, it would be nice to make it so that delimit-columns-region
> delegates to delimit-columns-rectangle when called with a rectangular
> region (i.e. using rectangle-mark-mode).

Good idea.  How about the second patch attached here?

Thanks,
Stefan Kangas

Attachment: 0001-Use-lexical-binding-in-delim-col.el-and-add-tests-5.patch
Description: Text Data

Attachment: 0002-Delegate-to-rectangle-version-in-delim-col-when-appr.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]