Re: Fill column indicator functionality

[Óscar Fuentes]

Ergus <address@hidden> writes:

> +;;;###autoload
> +(define-minor-mode display-fill-column-indicator-mode
> +  "Toggle display fill column indicator.
> +This uses `display-fill-column-indicator' internally.
> +
> +To change the position of the line displayed by default,
> +customize `display-fill-column-indicator-column' you can change the
> +character for the line setting
> `display-fill-column-indicator-character'."

It seems that you forgot to delete half of that docstring.

> @@ -20571,14 +20687,16 @@ highlight_trailing_whitespace (struct it *it)
>        if (!row->reversed_p)
>       {
>         while (glyph >= start
> -              && glyph->type == CHAR_GLYPH
> +              && (glyph->type == CHAR_GLYPH
> +                  || glyph->type == STRETCH_GLYPH)
>                && NILP (glyph->object))
>           --glyph;
>       }
>        else
>       {
>         while (glyph <= start
> -              && glyph->type == CHAR_GLYPH
> +              && (glyph->type == CHAR_GLYPH
> +                  || glyph->type == STRETCH_GLYPH)
>                && NILP (glyph->object))
>           ++glyph;
>       }

This hunk is rejected on `master'. 

> @@ -32645,6 +32763,9 @@ be let-bound around code that needs to disable 
> messages temporarily. */);
>    /* Name of a text property which disables line-number display.  */
>    DEFSYM (Qdisplay_line_numbers_disable, "display-line-numbers-disable");
>  
> +  /* Names of the face used to display fill column indicator character.  */

s/Names/Name

> +  DEFSYM (Qfill_column, "fill-column");
> +

Hmmm... is this right? Copy & pasto?

> +  DEFVAR_LISP ("display-fill-column-indicator-character", 
> Vdisplay_fill_column_indicator_character,
> +    doc: /* Character to draw the indicator when 
> `display-fill-column-indicator' is non-nil.
> +The default is U+2502 the but a good alternative is (ascii 124) if

"the but a good"

> +the font in fill-column-face supports Unicode characters.  */);

supports -> does not support ???


This feature is highly appreciated. Thank you.